Page MenuHomePhabricator

AMDGPU/R600: Emit rodata in text segment
ClosedPublic

Authored by jvesely on Jan 18 2020, 9:39 PM.

Details

Summary

R600 relies on this behaviour.
Fixes: 6e18266aa4dd78953557b8614cb9ff260bad7c65 ('Partially revert D61491 "AMDGPU: Be explicit about whether the high-word in SI_PC_ADD_REL_OFFSET is 0"')
Fixes ~100 piglit regressions since 6e18266

Diff Detail

Event Timeline

jvesely created this revision.Jan 18 2020, 9:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2020, 9:39 PM
arsenm accepted this revision.Jan 22 2020, 10:37 AM

LGTM

This revision is now accepted and ready to land.Jan 22 2020, 10:37 AM
This revision was automatically updated to reflect the committed changes.

This seems to break tests everywhere, e.g. http://45.33.8.238/linux/8152/step_12.txt

Please run tests before committing.

Please take a look, and if fixing this isn't obvious, please revert while you investigate.

Thanks!
sorry about the breakage