This is an archive of the discontinued LLVM Phabricator instance.

Include phabricator.uri in .arcconfig
ClosedPublic

Authored by phosek on Jan 17 2020, 2:41 PM.

Details

Summary

conduit_uri was renamed to phabricator.uri and git-phab fails to load
.arcconfig without this field.

Diff Detail

Event Timeline

phosek created this revision.Jan 17 2020, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2020, 2:41 PM
phosek added a reviewer: rnk.Jan 22 2020, 11:36 AM
rnk accepted this revision.Jan 22 2020, 3:24 PM

lgtm

This revision is now accepted and ready to land.Jan 22 2020, 3:24 PM
rnk added a comment.Jan 22 2020, 3:24 PM

By git-phab do you mean new versions of arcanist? I don't see a git-phab tool in tree.

I'm assuming git-phab is https://pypi.org/project/git-phab/

Yes, that ^. Someone mentioned it in the Phab/GitHub PR email thread as an alternative to arcanist so I'm giving it a try.

This revision was automatically updated to reflect the committed changes.