This is an archive of the discontinued LLVM Phabricator instance.

Differential D72957

[mlir] Unbreak MSVC build with implicit constructor
AbandonedPublic

Authored by nicolasvasilache on Jan 17 2020, 1:46 PM.

Details

Reviewers
stella.stamenova

Diff Detail

Unit TestsFailed

TimeTest
31,730 msLLVM.Bindings/Go::Unknown Unit Message ("")

Event Timeline

nicolasvasilache created this revision.Jan 17 2020, 1:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2020, 1:46 PM
Herald added subscribers: llvm-commits, liufengdb, lucyrfox and 8 others. · View Herald Transcript
nicolasvasilache added a reviewer: stellaraccident.Jan 17 2020, 1:49 PM
nicolasvasilache edited reviewers, added: stella.stamenova; removed: stellaraccident.

@stella.stamenova I am sorry but I do not have a simple way to fire up a Windows machine in a reasonable amount of time at this point.
Let's try to play it by ear, does this help?

Thanks!

nicolasvasilache added a comment.Jan 17 2020, 1:51 PM

Context: @stella.stamenova reported

##[error]mlir\include\mlir\IR\Attributes.h(234,0): Error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>'
   304>E:\agent\_work\4\s\mlir\include\mlir/IR/Attributes.h(234): error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>' [E:\agent\_work\4\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
   394>ClCompile:
         CGStmt.cpp
   304>ClCompile:
         E:\agent\_work\4\s\mlir\include\mlir/IR/Attributes.h(234): note: No constructor could take the source type, or constructor overload resolution was ambiguous
         E:\agent\_work\4\s\mlir\lib\Conversion\VectorToLLVM\ConvertVectorToLLVM.cpp(119): note: see reference to function template instantiation 'llvm::iterator_range<mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>> mlir::ArrayAttr::getAsRange<mlir::IntegerAttr>(void)' being compiled
##[error]mlir\include\mlir\IR\Attributes.h(235,0): Error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>'
   304>E:\agent\_work\4\s\mlir\include\mlir/IR/Attributes.h(235): error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>' [E:\agent\_work\4\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
         E:\agent\_work\4\s\mlir\include\mlir/IR/Attributes.h(235): note: No constructor could take the source type, or constructor overload resolution was ambiguous
##[error]mlir\include\mlir\IR\Attributes.h(234,0): Error C2672: 'llvm::make_range': no matching overloaded function found
   304>E:\agent\_work\4\s\mlir\include\mlir/IR/Attributes.h(234): error C2672: 'llvm::make_range': no matching overloaded function found [E:\agent\_work\4\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
##[error]mlir\include\mlir\IR\Attributes.h(235,0): Error C2780: 'llvm::iterator_range<IteratorT> llvm::make_range(T,T)': expects 2 arguments - 1 provided
   304>E:\agent\_work\4\s\mlir\include\mlir/IR/Attributes.h(235): error C2780: 'llvm::iterator_range<IteratorT> llvm::make_range(T,T)': expects 2 arguments - 1 provided [E:\agent\_work\4\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
         E:\agent\_work\4\s\llvm\include\llvm/ADT/iterator_range.h(54): note: see declaration of 'llvm::make_range'
merge_guards_bot added a subscriber: merge_guards_bot.Jan 17 2020, 2:10 PM

Unit tests: fail. 61983 tests passed, 1 failed and 783 were skipped.

failed: LLVM.Bindings/Go/go.test

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster failed remote builds in B44316: Diff 238882!Jan 17 2020, 2:15 PM
flaub added a subscriber: flaub.Jan 17 2020, 2:16 PM
stella.stamenova added a comment.Jan 17 2020, 2:43 PM

No difference (I would have been surprised, really, as the issue doesn't appear to be with the way the constructor is declared, but with how it is used):

         ConvertLoopToStandard.cpp
##[error]mlir\include\mlir\IR\Attributes.h(234,0): Error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>'
   303>E:\agent\_work\8\s\mlir\include\mlir/IR/Attributes.h(234): error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>' [E:\agent\_work\8\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
         E:\agent\_work\8\s\mlir\include\mlir/IR/Attributes.h(234): note: No constructor could take the source type, or constructor overload resolution was ambiguous
         E:\agent\_work\8\s\mlir\lib\Conversion\VectorToLLVM\ConvertVectorToLLVM.cpp(119): note: see reference to function template instantiation 'llvm::iterator_range<mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>> mlir::ArrayAttr::getAsRange<mlir::IntegerAttr>(void)' being compiled
##[error]mlir\include\mlir\IR\Attributes.h(235,0): Error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>'
   433>ClCompile:
         MacOSKeychainAPIChecker.cpp
   303>E:\agent\_work\8\s\mlir\include\mlir/IR/Attributes.h(235): error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>' [E:\agent\_work\8\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
         E:\agent\_work\8\s\mlir\include\mlir/IR/Attributes.h(235): note: No constructor could take the source type, or constructor overload resolution was ambiguous
##[error]mlir\include\mlir\IR\Attributes.h(234,0): Error C2672: 'llvm::make_range': no matching overloaded function found
   303>E:\agent\_work\8\s\mlir\include\mlir/IR/Attributes.h(234): error C2672: 'llvm::make_range': no matching overloaded function found [E:\agent\_work\8\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
##[error]mlir\include\mlir\IR\Attributes.h(235,0): Error C2780: 'llvm::iterator_range<IteratorT> llvm::make_range(T,T)': expects 2 arguments - 1 provided
   303>E:\agent\_work\8\s\mlir\include\mlir/IR/Attributes.h(235): error C2780: 'llvm::iterator_range<IteratorT> llvm::make_range(T,T)': expects 2 arguments - 1 provided [E:\agent\_work\8\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
         E:\agent\_work\8\s\llvm\include\llvm/ADT/iterator_range.h(54): note: see declaration of 'llvm::make_range'
   303>Done Building Project "E:\agent\_work\8\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj" (default targets) -- FAILED.
nicolasvasilache added a subscriber: aganea.Jan 17 2020, 4:00 PM

@stella.stamenova

I think this is related, see: https://developercommunity.visualstudio.com/content/problem/346421/c-code-with-initializer-list-does-not-compile-in-v.html
In particular:
Both GCC and Clang compile and run this code without any problems.
Note that MSVC 19.20 does compile the code correctly

@aganea mentioned: Visual Studio 2019 16.4.2

Do you have a possibility to try on the latest version on your end?
I do not

nicolasvasilache updated this revision to Diff 238924.Jan 17 2020, 4:09 PM

Explicitly resolve templated type in call to make_range.

nicolasvasilache added a comment.Jan 17 2020, 4:10 PM

actually I think the link I posted is not relevant, I tried explicitly instantiating the template in make_range, does that help?

nicolasvasilache updated this revision to Diff 238925.Jan 17 2020, 4:10 PM

Format.

merge_guards_bot added a comment.Jan 17 2020, 4:28 PM

Unit tests: fail. 61983 tests passed, 1 failed and 783 were skipped.

failed: LLVM.Bindings/Go/go.test

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster failed remote builds in B44329: Diff 238925!Jan 17 2020, 4:36 PM
merge_guards_bot added a comment.Jan 17 2020, 4:39 PM

Unit tests: fail. 61983 tests passed, 1 failed and 783 were skipped.

failed: LLVM.Bindings/Go/go.test

clang-tidy: unknown.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster failed remote builds in B44328: Diff 238924!Jan 17 2020, 4:46 PM
stella.stamenova added a comment.Jan 17 2020, 7:10 PM

With the latest VS 2019, the error is still the same (MSVC 19.24).

With the latest patch, the error is slightly different, but essentially the same problem:

##[error]mlir\include\mlir\IR\Attributes.h(235,0): Error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>'
   304>E:\agent\_work\5\s\mlir\include\mlir/IR/Attributes.h(235): error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>' [E:\agent\_work\5\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
         E:\agent\_work\5\s\mlir\include\mlir/IR/Attributes.h(235): note: No constructor could take the source type, or constructor overload resolution was ambiguous
         E:\agent\_work\5\s\mlir\lib\Conversion\VectorToLLVM\ConvertVectorToLLVM.cpp(119): note: see reference to function template instantiation 'llvm::iterator_range<mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>> mlir::ArrayAttr::getAsRange<mlir::IntegerAttr>(void)' being compiled
##[error]mlir\include\mlir\IR\Attributes.h(236,0): Error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>'
   304>E:\agent\_work\5\s\mlir\include\mlir/IR/Attributes.h(236): error C2440: '<function-style-cast>': cannot convert from 'mlir::ArrayAttr::iterator' to 'mlir::ArrayAttr::attr_value_iterator<mlir::IntegerAttr>' [E:\agent\_work\5\b\tools\mlir\lib\Conversion\VectorToLLVM\MLIRVectorToLLVM.vcxproj]
         E:\agent\_work\5\s\mlir\include\mlir/IR/Attributes.h(236): note: No constructor could take the source type, or constructor overload resolution was ambiguous
aganea added a comment.Jan 18 2020, 12:16 PM

Since you don't have Win machine, I took the liberty to fix it: rGe3d92b7442eaf3319f84bc060492df5b7ac3e9a1 (sorry, I didn't have the time to do it before)

flaub added a comment.Jan 18 2020, 12:32 PM

I think I found a solution to this, try:

explicit attr_value_iterator(ArrayAttr::iterator it)
    : llvm::mapped_iterator<ArrayAttr::iterator, AttrTy (*)(Attribute)>(
          it, [](Attribute attr) { return attr.cast<AttrTy>(); }) {}

Apparently MSVC is confused about the unqualified iterator identifier. Qualifying it with ArrayAttr:: seems to clear it up.

flaub added a comment.Jan 18 2020, 12:34 PM

Haha, aganea beat me to it :)

nicolasvasilache abandoned this revision.Jan 20 2020, 6:31 PM

Great, thanks @aganea !

Revision Contents

PathSize
mlir/
include/
mlir/
IR/
5 lines

Diff 238925

mlir/include/mlir/IR/Attributes.h

Show First 20 Lines • Show All 225 Lines • ▼ Show 20 Lines explicit attr_value_iterator(iterator it)
: llvm::mapped_iterator<iterator, AttrTy (*)(Attribute)>( : llvm::mapped_iterator<iterator, AttrTy (*)(Attribute)>(
it, [](Attribute attr) { return attr.cast<AttrTy>(); }) {} it, [](Attribute attr) { return attr.cast<AttrTy>(); }) {}
AttrTy operator*() { return (*this->I).template cast<AttrTy>(); } AttrTy operator*() { return (*this->I).template cast<AttrTy>(); }
}; };
public: public:
template <typename AttrTy> template <typename AttrTy>
llvm::iterator_range<attr_value_iterator<AttrTy>> getAsRange() { llvm::iterator_range<attr_value_iterator<AttrTy>> getAsRange() {
return llvm::make_range(attr_value_iterator<AttrTy>(begin()), return llvm::make_range<attr_value_iterator<AttrTy>>(
attr_value_iterator<AttrTy>(begin()),
attr_value_iterator<AttrTy>(end())); attr_value_iterator<AttrTy>(end()));
} }
}; };
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// BoolAttr // BoolAttr
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
class BoolAttr : public Attribute::AttrBase<BoolAttr, Attribute, class BoolAttr : public Attribute::AttrBase<BoolAttr, Attribute,
▲ Show 20 Lines • Show All 1,216 Lines • Show Last 20 Lines