[OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

[kkwli0]

Summary

Add missing OMP5.0 features.

[ABataev]

clang/docs/OpenMPSupport.rst

194

We have support only for unified memory, so must be partial

212

I assume, it is done.

218

Is this for Fortran?

242

What is this?

244

What kind of memory model update?

[jdoerfert]

clang/docs/OpenMPSupport.rst

194

Let's keep the explicit (unified shared memory) -> done line and add one for the others as not done.

[kkwli0]

clang/docs/OpenMPSupport.rst

242

This is a clarification. The spec add restrictions to declare new type on iterators, declare reduction and declare mapper [49:11; 308:17; 327:26]

[ABataev]

clang/docs/OpenMPSupport.rst

242

Would be good to put these links to the doc to make it clear

[kkwli0]

clang/docs/OpenMPSupport.rst

194

@ABataev It makes sense to make it partial.

@jdoerfert Keeping that line can be confusing. Line 196 is clear to indicate that the unified_address and unified_shared_memory parts of the requires directive is done.

[kkwli0]

clang/docs/OpenMPSupport.rst

244

We add five _memory-order-clause_s in the atomic directive - seq_cst, acq_rel, release, acquire and relaxed to support the memory model.

[ABataev]

clang/docs/OpenMPSupport.rst

244

I would add as much as possible info about expected features to the doc, if possible

[jdoerfert]

@kkwli0 I propose you can merge the parts where discussion has reached a consensus while the other parts are resolved. I'm generally fine with this, we can always improve on it further.

clang/docs/OpenMPSupport.rst

194

Fair point. thx.

218

No also C/C++.

242

Would be good to put these links to the doc to make it clear

Agreed. We have the HTML version of the standard online so we can do this "easily" but it will cost someone time and require to change the table layout. Let's postpone it for now until someone find some spare minutes.

244

I guess if they are unclaimed or done we can just list them in the description:

`memory model update (seq_cst, acq_rel, ...)`

and if we ever support a subset only we can make new rows for them.

[dreachem]

clang/docs/OpenMPSupport.rst

212

I think the description here should be something like "support close modifier on map clause". There is no "local" option for the map clause, and also the use of "close" is not dependent on the specification of the unified_shared_memory requirement.

[kkwli0]

clang/docs/OpenMPSupport.rst

218

Yep, it is not Fortran only. We clarify some pointer attachment behavior in 5.0.

242

Yes, it involves a significant change in the table if we include the corresponding text change in the table. In some cases, it is not clear from the original tickets. I think it is better to leave it as-is. If change the description can help, I welcome any suggestions.

[kkwli0]

Address review comments and rebase.

[kkwli0]

Ping

[ABataev]

clang/docs/OpenMPSupport.rst

194

As far as I understand we only support parsing/sema for unified_address.

218

Could add a reference to the section in the standard?

240–242

Could you add a reference to the standard?

[kkwli0]

Change requires unified_address status to partial.

[kkwli0]

clang/docs/OpenMPSupport.rst

218

I am not sure if this and another feature should be treated as special cases. If it is not, we will need to add references for all the features.

[ABataev]

LG, but still would be good to add some references to the standard. Some of the features use special wording, which very hard to find in the standard.

clang/docs/OpenMPSupport.rst

 | device extension             | structure mapping of references                              | :none:`unclaimed`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | nested target declare                                        | :good:`done`             | D51378                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | implicitly map 'this' (this[:1])                             | :good:`done`             | D55982                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | allow access to the reference count (omp_target_is_present)  | :part:`worked on`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
-| device extension             | requires directive (unified shared memory)                   | :good:`done`             |                                                                       |
+| device extension             | requires directive                                           | :part:`partial`          |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
-| device extension             | clause: unified_address, unified_shared_memory               | :good:`done`             | D52625,D52359                                                         |
+| device extension             | clause: unified_shared_memory                                | :good:`done`             | D52625,D52359                                                         |
++------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
+| device extension             | clause: unified_address                                      | :part:`partial`          |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | clause: reverse_offload                                      | :none:`unclaimed parts`  | D52780                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | clause: atomic_default_mem_rrder                             | :none:`unclaimed parts`  | D53513                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | clause: dynamic_allocators                                   | :none:`unclaimed parts`  | D53079                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | user-defined mappers                                         | :part:`worked on`        | D56326,D58638,D58523,D58074,D60972,D59474                             |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | mapping lambda expression                                    | :good:`done`             | D51107                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | clause: use_device_addr for target data                      | :part:`worked on`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
-| device extension             | map(replicate) or map(local) when requires unified_shared_me | :part:`worked on`        | D55719,D55892                                                         |
+| device extension             | support close modifier on map clause                         | :good:`done`             | D55719,D55892                                                         |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | teams construct on the host device                           | :part:`worked on`        | Clang part is done, r371553.                                          |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | device extension             | support non-contiguous array sections for target update      | :part:`worked on`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
+| device extension             | pointer attachment                                           | :none:`unclaimed`        |                                                                       |
++------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | atomic extension             | hints for the atomic construct                               | :part:`worked on`        | D51233                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | base language                | C11 support                                                  | :none:`unclaimed`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | base language                | C++11/14/17 support                                          | :part:`worked on`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | base language                | lambda support                                               | :good:`done`             |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | misc extension               | array shaping                                                | :none:`unclaimed`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | misc extension               | library shutdown (omp_pause_resource[_all])                  | :none:`unclaimed parts`  | D55078                                                                |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | misc extension               | metadirectives                                               | :none:`worked on`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | misc extension               | conditional modifier for lastprivate clause                  | :good:`done`             |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
+| misc extension               | iterator and multidependences                                | :none:`unclaimed`        |                                                                       |
++------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 | misc extension               | user-defined function variants                               | :part:`worked on`        | D67294, D64095                                                        |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
-| misc extensions              | pointer/reference to pointer based array reductions          | :none:`unclaimed`        |                                                                       |
+| misc extension               | pointer/reference to pointer based array reductions          | :none:`unclaimed`        |                                                                       |
++------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
+| misc extension               | prevent new type definitions in clauses                      | :none:`unclaimed`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
-| misc extensions              | prevent new type definitions in clauses                      | :none:`unclaimed`        |                                                                       |
+| memory model extension       | memory model update (seq_cst, acq_rel, release, acquire,...) | :none:`unclaimed`        |                                                                       |
 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
 
 
 OpenMP 5.1 Implementation Details
 =================================
 
 The following table provides a quick overview over various OpenMP 5.1 features
 and their implementation status, as defined in the technical report 8 (TR8).