This is an archive of the discontinued LLVM Phabricator instance.

Differential D72898

[lldb] add to gdb to lldb doc
ClosedPublic

Authored by cishida on Jan 16 2020, 6:56 PM.

Download Raw Diff

Details

Reviewers

Commits

rG24fca5cd7128: [lldb] add to gdb to lldb doc

Summary

enabling and disabling a breakpoint were missing.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

cishida created this revision.Jan 16 2020, 6:56 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2020, 6:56 PM

Herald added subscribers: lldb-commits, ributzka, dexonsmith. · View Herald Transcript

There's a copy paste error in the first header. Other than that, this is fine, thanks for adding the entries!

lldb/docs/use/map.rst
613	Shouldn't that be "Disable" not "Enable"

Unit tests: pass. 61936 tests passed, 0 failed and 783 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster completed remote builds in B44235: Diff 238686.Jan 16 2020, 7:22 PM

LGTM with Jim's comment addressed.

This revision is now accepted and ready to land.Jan 16 2020, 7:43 PM

Updating to fix copy/paste error

cishida marked an inline comment as done.Jan 16 2020, 7:51 PM

JDevlieghere accepted this revision.Jan 16 2020, 7:52 PM

Closed by commit rG24fca5cd7128: [lldb] add to gdb to lldb doc (authored by cishida). · Explain WhyJan 16 2020, 8:07 PM

This revision was automatically updated to reflect the committed changes.

Unit tests: pass. 61936 tests passed, 0 failed and 783 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster completed remote builds in B44236: Diff 238688.Jan 16 2020, 8:17 PM

Revision Contents

Path

Size

lldb/

docs/

use/

32 lines

Diff 238686

lldb/docs/use/map.rst

	Show First 20 Lines • Show All 603 Lines • ▼ Show 20 Lines		<table class="mapping" cellspacing="0">
	<td class="content">			<td class="content">
	<b>(lldb)</b> breakpoint delete 1			<b>(lldb)</b> breakpoint delete 1
	<br>			<br>
	<b>(lldb)</b> br del 1			<b>(lldb)</b> br del 1
	<br>			<br>
	</td>			</td>
	</tr>			</tr>

				<tr>
				<td class="header" colspan="2">Enable a breakpoint.</td>
				jinghamUnsubmitted Done Reply Inline Actions Shouldn't that be "Disable" not "Enable" jingham: Shouldn't that be "Disable" not "Enable"
				</tr>
				<tr>
				<td class="content">
				<b>(gdb)</b> disable 1
				<br>
				</td>
				<td class="content">
				<b>(lldb)</b> breakpoint disable 1
				<br>
				<b>(lldb)</b> br dis 1
				<br>
				</td>
				</tr>

				<tr>
				<td class="header" colspan="2">Enable a breakpoint.</td>
				</tr>
				<tr>
				<td class="content">
				<b>(gdb)</b> enable 1
				<br>
				</td>
				<td class="content">
				<b>(lldb)</b> breakpoint enable 1
				<br>
				<b>(lldb)</b> br en 1
				<br>
				</td>
				</tr>

	</tbody>			</tbody>
	</table>			</table>


	Watchpoint Commands			Watchpoint Commands
	-------------------			-------------------

	.. raw:: html			.. raw:: html
	▲ Show 20 Lines • Show All 1,174 Lines • Show Last 20 Lines