Page MenuHomePhabricator

AMDGPU: Don't assert on a16 images on targets without FeatureR128A16
ClosedPublic

Authored by arsenm on Jan 16 2020, 12:47 PM.

Details

Reviewers
nhaehnle
rampitec
Summary

Currently the lowering for i16 image coordinates asserts on gfx10. I'm
somewhat confused by this though. The feature is missing from the
gfx10 feature lists, but the a16 bit appears to be present in the
manual for MIMG instructions.

Diff Detail

Event Timeline

arsenm created this revision.Jan 16 2020, 12:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2020, 12:48 PM

I think we need to add FeatureR128A16 to GFX10. ISA spec says it does support it.

This revision is now accepted and ready to land.Jan 16 2020, 1:18 PM
arsenm closed this revision.Jan 17 2020, 8:07 AM

886f9071c63848e90fe0c2f3ad98a0a71aeffcd4

I think we need to add FeatureR128A16 to GFX10. ISA spec says it does support it.

This still ends up being an issue on older targets though, so I've changed the test cpu