Page MenuHomePhabricator

[SLP] Add a test showing miscompilation in AltOpcode support
ClosedPublic

Authored by a.elovikov on Jan 14 2020, 3:06 PM.

Diff Detail

Event Timeline

a.elovikov created this revision.Jan 14 2020, 3:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2020, 3:06 PM
ABataev added inline comments.
llvm/test/Transforms/SLPVectorizer/X86/no_alternate_divrem.ll
5–6

Better to pass these as parameters of opt.

135

Same here, pass as a parameter of opt instead.

Pass tripple/target-cpu via opt's --triple/--mcpu options

ABataev added inline comments.Jan 14 2020, 5:43 PM
llvm/test/Transforms/SLPVectorizer/X86/no_alternate_divrem.ll
5

Same with this one, if required, pass it as a parameter of opt

Remove target datalayout string from the test

This revision is now accepted and ready to land.Jan 15 2020, 8:42 AM
RKSimon accepted this revision.Jan 15 2020, 8:42 AM

LGTM

This revision was automatically updated to reflect the committed changes.