[SLP] Add a test showing miscompilation in AltOpcode support
ClosedPublic
Actions

Authored by a.elovikov on Jan 14 2020, 3:06 PM.

Details

Reviewers

Vasilis
RKSimon
ABataev

Commits

rGd64ca7abe191: [SLP] Add a test showing miscompilation in AltOpcode support
rG757fe53994c1: [SLP] Add a test showing miscompilation in AltOpcode support

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

a.elovikov created this revision.Jan 14 2020, 3:06 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2020, 3:06 PM

Herald added subscribers: dexonsmith, inglorion. · View Herald Transcript

Harbormaster completed remote builds in B44008: Diff 238116.Jan 14 2020, 3:14 PM

ABataev added a subscriber: ABataev.Jan 14 2020, 4:02 PM

ABataev added inline comments.

llvm/test/Transforms/SLPVectorizer/X86/no_alternate_divrem.ll
5–6	Better to pass these as parameters of opt.
135	Same here, pass as a parameter of opt instead.

Pass tripple/target-cpu via opt's --triple/--mcpu options

Harbormaster completed remote builds in B44018: Diff 238150.Jan 14 2020, 5:42 PM

ABataev added inline comments.Jan 14 2020, 5:43 PM

llvm/test/Transforms/SLPVectorizer/X86/no_alternate_divrem.ll
5	Same with this one, if required, pass it as a parameter of opt

Remove target datalayout string from the test

Harbormaster completed remote builds in B44056: Diff 238273.Jan 15 2020, 8:26 AM

This revision is now accepted and ready to land.Jan 15 2020, 8:42 AM

LGTM

RKSimon mentioned this in D72740: [SLP] Don't allow Div/Rem as alternate opcodes.Jan 15 2020, 8:43 AM

Closed by commit rG757fe53994c1: [SLP] Add a test showing miscompilation in AltOpcode support (authored by a.elovikov). · Explain WhyJan 21 2020, 2:23 PM

This revision was automatically updated to reflect the committed changes.

Cherry-picked to 10.x in d64ca7abe191e5813ab171df325f2cc2693dae21

Revision Contents
Changeset List

Path

Size

llvm/

test/

Transforms/

SLPVectorizer/

X86/

no_alternate_divrem.ll

131 lines

Diff 239434

View Options

llvm/test/Transforms/SLPVectorizer/X86/no_alternate_divrem.ll

[SLP] Add a test showing miscompilation in AltOpcode supportClosedPublicActions