This is an archive of the discontinued LLVM Phabricator instance.

Differential D72718

[llvm-nm] Use `StringRef` over `const std::string &` params
ClosedPublic

Authored by sbc100 on Jan 14 2020, 9:49 AM.

Details

Reviewers
jhenderson
Commits
rGfa4112fffc6b: [llvm-nm] Use `StringRef` over `const std::string &` params

Diff Detail

Event Timeline

sbc100 created this revision.Jan 14 2020, 9:49 AM
Herald added a reviewer: jhenderson. · View Herald TranscriptJan 14 2020, 9:49 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, rupprecht, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B43962: Diff 238016.Jan 14 2020, 9:55 AM
jhenderson accepted this revision.Jan 15 2020, 12:54 AM

LGTM.

This revision is now accepted and ready to land.Jan 15 2020, 12:54 AM
sbc100 updated this revision to Diff 238610.Jan 16 2020, 2:00 PM
  • rebase
sbc100 updated this revision to Diff 238613.Jan 16 2020, 2:03 PM

clang-format

Closed by commit rGfa4112fffc6b: [llvm-nm] Use `StringRef` over `const std::string &` params (authored by sbc100). · Explain WhyJan 16 2020, 2:06 PM
This revision was automatically updated to reflect the committed changes.
sbc100 mentioned this in D72658: [llvm-nm] Don't report "no symbols" error for files that contain symbols.Jan 16 2020, 2:09 PM
merge_guards_bot added a subscriber: merge_guards_bot.Jan 16 2020, 2:20 PM

Unit tests: pass. 61934 tests passed, 0 failed and 783 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster completed remote builds in B44203: Diff 238613.Jan 16 2020, 2:24 PM
merge_guards_bot added a comment.Jan 16 2020, 2:32 PM

Unit tests: pass. 61906 tests passed, 0 failed and 782 were skipped.

clang-tidy: unknown.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Harbormaster failed remote builds in B44201: Diff 238610!Jan 16 2020, 2:34 PM

Revision Contents

PathSize
llvm/
tools/
llvm-nm/
8 lines

Diff 238610

llvm/tools/llvm-nm/llvm-nm.cpp

Show First 20 Lines • Show All 702 Lines • ▼ Show 20 Linesstatic Optional<std::string> demangle(StringRef Name, bool StripUnderscore) {
return S; return S;
} }
static bool symbolIsDefined(const NMSymbol &Sym) { static bool symbolIsDefined(const NMSymbol &Sym) {
return Sym.TypeChar != 'U' && Sym.TypeChar != 'w' && Sym.TypeChar != 'v'; return Sym.TypeChar != 'U' && Sym.TypeChar != 'w' && Sym.TypeChar != 'v';
} }
static void sortAndPrintSymbolList(SymbolicFile &Obj, bool printName, static void sortAndPrintSymbolList(SymbolicFile &Obj, bool printName,
const std::string &ArchiveName, StringRef ArchiveName,
const std::string &ArchitectureName) { StringRef ArchitectureName) {
if (!NoSort) { if (!NoSort) {
using Comparator = bool (*)(const NMSymbol &, const NMSymbol &); using Comparator = bool (*)(const NMSymbol &, const NMSymbol &);
Comparator Cmp; Comparator Cmp;
if (NumericSort) if (NumericSort)
Cmp = &compareSymbolAddress; Cmp = &compareSymbolAddress;
else if (SizeSort) else if (SizeSort)
Cmp = &compareSymbolSize; Cmp = &compareSymbolSize;
else else
▲ Show 20 Lines • Show All 458 Lines • ▼ Show 20 Linesstatic unsigned getNsectInMachO(MachOObjectFile &Obj, BasicSymbolRef Sym) {
if (Obj.is64Bit()) { if (Obj.is64Bit()) {
MachO::nlist_64 STE = Obj.getSymbol64TableEntry(Symb); MachO::nlist_64 STE = Obj.getSymbol64TableEntry(Symb);
return (STE.n_type & MachO::N_TYPE) == MachO::N_SECT ? STE.n_sect : 0; return (STE.n_type & MachO::N_TYPE) == MachO::N_SECT ? STE.n_sect : 0;
} }
MachO::nlist STE = Obj.getSymbolTableEntry(Symb); MachO::nlist STE = Obj.getSymbolTableEntry(Symb);
return (STE.n_type & MachO::N_TYPE) == MachO::N_SECT ? STE.n_sect : 0; return (STE.n_type & MachO::N_TYPE) == MachO::N_SECT ? STE.n_sect : 0;
} }
static void static void
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static void
-dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName,
-                          StringRef ArchiveName = {},
-                          StringRef ArchitectureName = {}) {
+static void dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName,
+                                      StringRef ArchiveName = {},
+                                      StringRef ArchitectureName = {}) {
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static void -dumpSymbolNamesFromObject(SymbolicFile…
dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName, dumpSymbolNamesFromObject(SymbolicFile &Obj, bool printName,
const std::string &ArchiveName = std::string(), StringRef ArchiveName = {},
const std::string &ArchitectureName = std::string()) { StringRef ArchitectureName = {}) {
auto Symbols = Obj.symbols(); auto Symbols = Obj.symbols();
if (DynamicSyms) { if (DynamicSyms) {
const auto *E = dyn_cast<ELFObjectFileBase>(&Obj); const auto *E = dyn_cast<ELFObjectFileBase>(&Obj);
if (!E) { if (!E) {
error("File format has no dynamic symbol table", Obj.getFileName()); error("File format has no dynamic symbol table", Obj.getFileName());
return; return;
} }
Symbols = E->getDynamicSymbolIterators(); Symbols = E->getDynamicSymbolIterators();
▲ Show 20 Lines • Show All 942 Lines • Show Last 20 Lines