Page MenuHomePhabricator

[nfc][libomptarget] Refactor amdgcn target_impl
ClosedPublic

Authored by JonChesterfield on Jan 14 2020, 8:51 AM.

Details

Summary

[nfc][libomptarget] Refactor amdgcn target_impl

Removes references to internal libraries from the header
Standardises on C++ mangling for all the target_impl functions
Update comment block
clang-format
Move some functions into a new target_impl.hip source file

This lays the groundwork for implementing the remaining unresolved
symbols in the target_impl.hip source.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2020, 8:51 AM
This revision is now accepted and ready to land.Jan 14 2020, 11:17 AM
This revision was automatically updated to reflect the committed changes.