This is an archive of the discontinued LLVM Phabricator instance.

[clang][OpenCL] Fix covered switch warning
ClosedPublic

Authored by jsji on Jan 14 2020, 7:56 AM.

Details

Summary

-Werror clang build is broken now.

tools/clang/lib/Sema/OpenCLBuiltins.inc:11824:5: error: default label in
switch which covers all enumeration values
[-Werror,-Wcovered-switch-default]

default:

We don't need default now, since all enumeration values are covered.

Diff Detail

Event Timeline

jsji created this revision.Jan 14 2020, 7:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2020, 7:56 AM
jsji edited the summary of this revision. (Show Details)Jan 14 2020, 7:59 AM
svenvh accepted this revision.Jan 14 2020, 8:15 AM

Nice catch, LGTM. Thanks!

This revision is now accepted and ready to land.Jan 14 2020, 8:15 AM

Unit tests: pass. 61822 tests passed, 0 failed and 781 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

This revision was automatically updated to reflect the committed changes.