Page MenuHomePhabricator

[mlir] Enable printing of FuncOp in the generic form.
ClosedPublic

Authored by rriddle on Jan 13 2020, 1:07 PM.

Details

Summary

This was previously disabled as FunctionType TypeAttrs could not be roundtripped in the IR. This has been fixed, so we can now generically print FuncOp.

Depends On D72429

Diff Detail

Event Timeline

rriddle created this revision.Jan 13 2020, 1:07 PM

Unit tests: fail. 61795 tests passed, 1 failed and 781 were skipped.

failed: MLIR.EDSC/builder-api-test.cpp

clang-tidy: unknown.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

mehdi_amini accepted this revision.Jan 13 2020, 10:37 PM
mehdi_amini added inline comments.
mlir/test/IR/wrapping_op.mlir
5

I'd match the sym_name: "wrapping_op" as well

This revision is now accepted and ready to land.Jan 13 2020, 10:37 PM
jpienaar accepted this revision.Jan 14 2020, 8:16 AM
rriddle updated this revision to Diff 238118.Jan 14 2020, 3:08 PM

Address comments

rriddle marked an inline comment as done.Jan 14 2020, 3:09 PM
This revision was automatically updated to reflect the committed changes.

Unit tests: pass. 61804 tests passed, 0 failed and 781 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml