Page MenuHomePhabricator

[compiler-rt/cmake] Don't attempt to ad-hoc sign for OS X
Needs ReviewPublic

Authored by loladiro on Jan 13 2020, 8:54 AM.

Details

Summary

Revision rL301443 added an ad-hoc codesigning step when building compiler-rt
dylibs. My understanding is that this is needed for testing such dylibs in
the iOS simulator. However, adding such a step is problematic for cross
compilation to OS X from other platforms, as the codesign utility is
generally not available in a cross compilation environment. Since there is
AFAIK no benefit to ad-hoc signing these libraries on OS X, restrict the
extra codesign step to IOS.

Event Timeline

loladiro created this revision.Jan 13 2020, 8:54 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 13 2020, 8:54 AM
Herald added subscribers: llvm-commits, Restricted Project, mgorny, dberris. · View Herald Transcript