This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Portability fix of std::strstreambuf constructor test.
ClosedPublic

Authored by amakc11 on Jan 9 2020, 10:16 AM.

Details

Summary

The standard does not require the constructor strstreambuf(streamsize alsize_arg = 0) leave the stream array unallocated when called with parameter alsize_arg > 0. Conformant implementations of this constructor may allocate minimal alsize_arg number of bytes forcing str() method to return non-null pointer.

Diff Detail

Event Timeline

amakc11 created this revision.Jan 9 2020, 10:16 AM
Herald added a project: Restricted Project. · View Herald Transcript
ldionne accepted this revision.May 14 2020, 6:41 AM
This revision is now accepted and ready to land.May 14 2020, 6:41 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 6:41 AM
This revision now requires review to proceed.May 14 2020, 6:41 AM
ldionne accepted this revision.May 14 2020, 6:41 AM
This revision is now accepted and ready to land.May 14 2020, 6:41 AM