Page MenuHomePhabricator

amakc11 (Andrey Maksimov)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 16 2018, 9:41 AM (61 w, 4 h)

Recent Activity

Mon, Jan 13

amakc11 updated the diff for D71908: [libcxx] [test] Include missing <limits> header..

Detected one more file missing this header. Diff is updated.

Mon, Jan 13, 7:16 AM · Restricted Project

Fri, Jan 10

amakc11 created D72520: [libcxx] [test] Portability fix of std::basic_filebuf::overflow() test..
Fri, Jan 10, 9:43 AM · Restricted Project

Thu, Jan 9

amakc11 created D72465: [libcxx] [test] Portability fix of std::strstreambuf constructor test..
Thu, Jan 9, 10:23 AM · Restricted Project
amakc11 created D72456: [libcxx] [test] Portability fix for some locale-dependent tests..
Thu, Jan 9, 7:43 AM · Restricted Project

Fri, Dec 27

amakc11 added a comment to D71908: [libcxx] [test] Include missing <limits> header..

I have no commit access to Monorepo. Somebody should commit this revision. Thanks.

Fri, Dec 27, 6:22 AM · Restricted Project

Thu, Dec 26

amakc11 added a comment to D55777: [libcxx] Portability fix: add missing includes and static_casts..

ping

Thu, Dec 26, 9:19 AM
amakc11 created D71908: [libcxx] [test] Include missing <limits> header..
Thu, Dec 26, 9:10 AM · Restricted Project

Jun 3 2019

amakc11 added a comment to D62816: [libcxx] Add test to check min/max requirement to regular expression..

I don't understand the request. Please, clarify. Also, it would help if you use the terms from the comments in the suggested test.

Jun 3 2019, 7:06 PM · Restricted Project
amakc11 created D62816: [libcxx] Add test to check min/max requirement to regular expression..
Jun 3 2019, 9:47 AM · Restricted Project

May 22 2019

amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

I'm going to commit this for you, however you should consider getting commit access (https://llvm.org/docs/DeveloperPolicy.html) since you've done a couple of patches.

Thanks for suggestion. I'll consider it.

May 22 2019, 11:34 AM · Restricted Project
amakc11 updated the diff for D56500: [libcxx] Fix order checking in unordered_multiset tests..

More simplifications accepted and committed in D56498 are implemented here: common function moved to a separate header file. Now this patch can also be accepted and committed.

May 22 2019, 11:29 AM · Restricted Project
amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

Yet another personal ping for @EricWF. Let's finish up with this finally and proceed with the project.

May 22 2019, 9:16 AM · Restricted Project

May 20 2019

amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

I'll commit this is the morning.

May 20 2019, 1:17 PM · Restricted Project
amakc11 added inline comments to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..
May 20 2019, 7:31 AM · Restricted Project

May 17 2019

amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

Would somebody commit this, please?

May 17 2019, 5:13 PM · Restricted Project
amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

Another personal ping for @EricWF. If you have any questions, please ask. If not, please accept and commit.

May 17 2019, 7:54 AM · Restricted Project

May 6 2019

amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

Ping for @EricWF: project must go on.

May 6 2019, 6:57 AM · Restricted Project

Apr 29 2019

amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

If there are still questions/suggestions, please ask/post.

Apr 29 2019, 3:19 PM · Restricted Project

Apr 26 2019

amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

We are now very close to the end here. Let's finish this up.

Apr 26 2019, 9:09 AM · Restricted Project
amakc11 added a comment to D61192: [libcxx] Add precondition check before calling match_results.str() in tests..

If you agree, I can just make the changes myself.

Yes, please.

Apr 26 2019, 9:09 AM
amakc11 created D61195: [libcxx] Portability fix: std::regex_constants::error_type values are not requied to be non-zero..
Apr 26 2019, 8:42 AM · Restricted Project
amakc11 created D61192: [libcxx] Add precondition check before calling match_results.str() in tests..
Apr 26 2019, 8:24 AM

Apr 23 2019

amakc11 updated the diff for D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

Suggestions implemented. Common functions moved to a separate header file. This header will also be used to simplify code in patch D56500 after this one is accepted and committed.

Apr 23 2019, 8:36 AM · Restricted Project

Apr 22 2019

amakc11 added inline comments to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..
Apr 22 2019, 12:12 PM · Restricted Project
amakc11 updated the diff for D56500: [libcxx] Fix order checking in unordered_multiset tests..

Suggested simplification implemented. It also implemented for the associated patch D56498.

Apr 22 2019, 7:40 AM · Restricted Project
amakc11 updated the diff for D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

Simplification suggested by Marshall Clow implemented.

Apr 22 2019, 7:36 AM · Restricted Project

Apr 18 2019

amakc11 added a comment to D56500: [libcxx] Fix order checking in unordered_multiset tests..

If you have any further questions, please ask. If not, please accept and commit.

Apr 18 2019, 4:40 PM · Restricted Project

Mar 11 2019

amakc11 added a comment to D56500: [libcxx] Fix order checking in unordered_multiset tests..

ping

Mar 11 2019, 10:49 AM · Restricted Project

Feb 27 2019

amakc11 created D58732: [libcxx] Portability fix: close an open file stream before removing the file..
Feb 27 2019, 11:54 AM

Feb 21 2019

amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

ping

Feb 21 2019, 4:52 AM · Restricted Project

Feb 15 2019

amakc11 created D58299: [libcxx] Portability fix: make std::io_base::xalloc() test independent on initial index value..
Feb 15 2019, 12:12 PM · Restricted Project

Feb 13 2019

amakc11 updated the diff for D57903: [libcxx] Add missing checks to tests for the move w/allocator constructors of associative containers..

Agree. Patch modified as suggested.

Feb 13 2019, 7:35 AM

Feb 12 2019

amakc11 added inline comments to D57903: [libcxx] Add missing checks to tests for the move w/allocator constructors of associative containers..
Feb 12 2019, 1:07 PM

Feb 11 2019

amakc11 added a comment to rCXX353668: Update some newly added files that mistakenly used the old file header.

Your change list looks incomplete. Consider using grep:

Feb 11 2019, 10:55 AM

Feb 7 2019

amakc11 created D57903: [libcxx] Add missing checks to tests for the move w/allocator constructors of associative containers..
Feb 7 2019, 9:37 AM
amakc11 added a comment to D56500: [libcxx] Fix order checking in unordered_multiset tests..

Is the patch rejected due to being "difficult to follow"?

Feb 7 2019, 8:22 AM · Restricted Project

Feb 5 2019

amakc11 updated the diff for D57704: [libcxx] Tests cleanup: use UNSUPPORTED instead of TEST_STD_VER..

Patch is rebased as requested.

Feb 5 2019, 6:36 AM

Feb 4 2019

amakc11 added a comment to D57704: [libcxx] Tests cleanup: use UNSUPPORTED instead of TEST_STD_VER..

Oops, seems like a "commit race" happened. :-)

Feb 4 2019, 12:59 PM
amakc11 created D57704: [libcxx] Tests cleanup: use UNSUPPORTED instead of TEST_STD_VER..
Feb 4 2019, 11:50 AM

Jan 31 2019

amakc11 updated the diff for D57391: [libcxx] Portability fix: regex algorithms exceptions made optional..

// UNSUPPORTED: libcpp-no-exceptions added. I ran the new test against libc++ in c++98 and c++03 modes once again to make sure it passes. It means that // UNSUPPORTED: c++98, c++03; is not needed for the reason I mentioned in my previous comment.

Jan 31 2019, 6:59 AM

Jan 30 2019

amakc11 added a comment to D57391: [libcxx] Portability fix: regex algorithms exceptions made optional..

Other than the missing // UNSUPPORTED bits, this looks good to me.
Do you need me to commit this?

Jan 30 2019, 1:08 PM

Jan 29 2019

amakc11 added inline comments to rCXX352512: Mark some of the behavior in the move w/allocator constructors of….
Jan 29 2019, 6:26 PM
amakc11 created D57391: [libcxx] Portability fix: regex algorithms exceptions made optional..
Jan 29 2019, 9:20 AM

Jan 28 2019

amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

The answer is here. If you don't agree with it, please, suggest simpler patch with the same test coverage.

Jan 28 2019, 6:09 PM · Restricted Project
amakc11 added a comment to D56500: [libcxx] Fix order checking in unordered_multiset tests..

Wouldn't it be enough (and simpler) to do something like this

Jan 28 2019, 6:02 PM · Restricted Project

Jan 24 2019

amakc11 added a comment to D56500: [libcxx] Fix order checking in unordered_multiset tests..

ping

Jan 24 2019, 12:05 PM · Restricted Project
amakc11 added a comment to D56498: [libcxx] Fix order checking in some more unordered_multimap tests..

ping

Jan 24 2019, 12:05 PM · Restricted Project
amakc11 added a comment to D56493: [libcxx] Portability fix: unordered_set and unordered_multiset iterators are not required to be the same..

Yes, I am. The same is true for all other my patches awaiting review.

Jan 24 2019, 9:46 AM
amakc11 added a comment to D56493: [libcxx] Portability fix: unordered_set and unordered_multiset iterators are not required to be the same..

ping

Jan 24 2019, 9:05 AM

Jan 22 2019

amakc11 updated the diff for D56503: [libcxx] Portability fix: add missing includes..

For complete consistency with this request, two more tests were patched. Calls to strcmp() replaced with std::strcmp() and <cstring> header added according to the requirement of the standard. The test std/depr/depr.c.headers/string_h.pass.cpp remains untouched since it checks the requirements to <string.h> header.

Jan 22 2019, 7:41 AM

Jan 21 2019

amakc11 added a comment to D56503: [libcxx] Portability fix: add missing includes..

ping

Jan 21 2019, 7:26 AM

Jan 14 2019

amakc11 added inline comments to D56503: [libcxx] Portability fix: add missing includes..
Jan 14 2019, 11:00 AM

Jan 10 2019

amakc11 added inline comments to rCXX350772: [NFC] Always lock free test: add indirection.
Jan 10 2019, 10:01 AM

Jan 9 2019

amakc11 created D56503: [libcxx] Portability fix: add missing includes..
Jan 9 2019, 10:22 AM
amakc11 created D56500: [libcxx] Fix order checking in unordered_multiset tests..
Jan 9 2019, 9:59 AM · Restricted Project
amakc11 created D56498: [libcxx] Fix order checking in some more unordered_multimap tests..
Jan 9 2019, 9:20 AM · Restricted Project
amakc11 created D56493: [libcxx] Portability fix: unordered_set and unordered_multiset iterators are not required to be the same..
Jan 9 2019, 7:35 AM

Dec 19 2018

amakc11 added a comment to D55777: [libcxx] Portability fix: add missing includes and static_casts..

With respect to this particular patch, I would rather wait for the final verdict on the Clang bug Marshall reported recently. If it is a real bug in compiler, than the patch should be considered as both a portability fix and a bug catcher.

Dec 19 2018, 12:24 PM

Dec 18 2018

amakc11 added a comment to D55777: [libcxx] Portability fix: add missing includes and static_casts..

I don't use clang. The log of running tests including poisoned_hash_helper.hpp is attached.

Dec 18 2018, 6:38 PM
amakc11 updated the diff for D55777: [libcxx] Portability fix: add missing includes and static_casts..

The includes look fine. The static_casts (as always) look ugly. Once you make the changes that I've requested, you can commit this.

The requested changes applied. I can't commit the patch myself: I don't have rights to do this.

Dec 18 2018, 10:28 AM

Dec 17 2018

amakc11 created D55777: [libcxx] Portability fix: add missing includes and static_casts..
Dec 17 2018, 10:42 AM

Dec 10 2018

amakc11 added a comment to D54838: [libcxx] Fix order checking in unordered_multimap tests..

Is this patch rejected? BTW, since git repository is used to store tests, the copy of any previous version of the patched tests can be made any time after the patch is applied.

Dec 10 2018, 8:41 AM

Dec 6 2018

amakc11 added a comment to D55366: [libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end() ..

Yes, but that's just true for libc++. Other library maintainers use these tests, too.

It is also true for GNU libstdc++.

Dec 6 2018, 10:53 AM
amakc11 updated the diff for D55366: [libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end() ..

Sorry. Fixed.

Dec 6 2018, 10:33 AM
amakc11 updated the diff for D55366: [libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end() ..

In libc++ these array iterators declared as follows:

Dec 6 2018, 6:40 AM
amakc11 created D55366: [libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end() ..
Dec 6 2018, 5:44 AM
amakc11 updated the summary of D55364: [libcxx] Portability fix: make return value of array<T, 0>.data() checked only for libc++..
Dec 6 2018, 5:05 AM
amakc11 created D55364: [libcxx] Portability fix: make return value of array<T, 0>.data() checked only for libc++..
Dec 6 2018, 5:01 AM

Dec 4 2018

amakc11 added a comment to D54838: [libcxx] Fix order checking in unordered_multimap tests..

ping

Dec 4 2018, 7:41 AM

Nov 27 2018

amakc11 updated the diff for D54838: [libcxx] Fix order checking in unordered_multimap tests..

Initializer-list construction replaced with insert() throughout the tests.

Could you please keep the order-dependent tests in a suitably-named file under test/libcxx/<...> instead of test/std/<...>? Tests under test/libcxx/ are libc++-specific.

I would suggest someone from libc++ test suite developers/maintainers team to do this, if it is necessary for them, before the patch is applied to test/std/<...> tests. I'm not a member of this team, but just yet another external user of test/std/<...> tests. So, I'd like to avoid intervening into another expert team's job by trying to solve their internal tasks having no sufficient expertize to do this.

Nov 27 2018, 7:42 AM

Nov 26 2018

amakc11 added a comment to D54838: [libcxx] Fix order checking in unordered_multimap tests..

Hmm, I'm confused by this change request. All the tests I patched are intended to test unordered_multimap container, which was introduced in C++11. So, they won't compile in C++03 mode in any case. Please, clarify the reason for the patch change.

Nov 26 2018, 12:46 PM

Nov 22 2018

amakc11 created D54838: [libcxx] Fix order checking in unordered_multimap tests..
Nov 22 2018, 12:37 PM

Nov 21 2018

amakc11 updated the diff for D54806: [libcxx] Fix incorrect iterator type in vector container test..

Missing space restored. Type name changed according to the coding standard (sorry, I prefer readable identifiers by default).

Nov 21 2018, 12:24 PM
amakc11 added a comment to D54806: [libcxx] Fix incorrect iterator type in vector container test..

However, I don't this SCARY iterators are actually required by the standard (am I wrong?).

Nov 21 2018, 12:21 PM
amakc11 added a comment to D54806: [libcxx] Fix incorrect iterator type in vector container test..

BTW, which tests in the test suite are meant to check for SCARY iterators?

Nov 21 2018, 11:44 AM
amakc11 updated the diff for D54806: [libcxx] Fix incorrect iterator type in vector container test..

typedef added throughout the test to avoid confusion whether the implemented test actions are meant to check for SCARY iterators.

Nov 21 2018, 11:42 AM
amakc11 added a comment to D54806: [libcxx] Fix incorrect iterator type in vector container test..

My intention was to be consistent with the #if TEST_STD_VER >= 11 segment of the test, which does not introduce any typedef in the similar context. Should I change both?

Nov 21 2018, 10:59 AM
amakc11 created D54806: [libcxx] Fix incorrect iterator type in vector container test..
Nov 21 2018, 10:42 AM

Nov 19 2018

amakc11 added a comment to D54645: [libcxx] [test] Portability fix: add missing header for std::max_align_t..

Look also at this revision.

Nov 19 2018, 9:04 AM
amakc11 created D54705: [libcxx] [test] Portability fix: change header for struct hash..
Nov 19 2018, 8:48 AM

Nov 16 2018

amakc11 created D54645: [libcxx] [test] Portability fix: add missing header for std::max_align_t..
Nov 16 2018, 12:53 PM
amakc11 added a comment to D54643: [libcxx] [test] Portability fix: add missing headers to unordered containers tests..

No, I don't.

Nov 16 2018, 11:43 AM
amakc11 created D54643: [libcxx] [test] Portability fix: add missing headers to unordered containers tests..
Nov 16 2018, 11:35 AM