Page MenuHomePhabricator

[clangd] Improve type printing in hover
ClosedPublic

Authored by kadircet on Jan 9 2020, 6:32 AM.

Details

Summary

Do not include tag keywords when printing types for symbol names, as it
will come from SymbolKind.
Also suppress them while printing definitions to prevent them occuring in
template arguments.
Make use of getAsString, instead of print in all places to have a consistent
style across the file.

Diff Detail

Event Timeline

kadircet created this revision.Jan 9 2020, 6:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2020, 6:32 AM

Unit tests: pass. 61327 tests passed, 0 failed and 738 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

This revision is now accepted and ready to land.Jan 10 2020, 12:18 AM
This revision was automatically updated to reflect the committed changes.