Page MenuHomePhabricator

[Driver][PowerPC] Move powerpcspe logic from cc1 to Driver
ClosedPublic

Authored by MaskRay on Jan 8 2020, 8:58 PM.

Details

Summary

Follow-up of D72014. It is more appropriate to use a target
feature instead of a SubTypeArch to express the difference.

Diff Detail

Event Timeline

MaskRay created this revision.Jan 8 2020, 8:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2020, 8:58 PM

Unit tests: pass. 61322 tests passed, 0 failed and 737 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

MaskRay updated this revision to Diff 236961.Jan 8 2020, 9:36 PM
MaskRay retitled this revision from [PowerPC] Change SubArchType if -mspe is specified to [Driver][PowerPC] Move powerpcspe logic from cc1 to Driver.
MaskRay edited the summary of this revision. (Show Details)
MaskRay removed subscribers: wuzish, merge_guards_bot.

Repurpose

MaskRay added a reviewer: dim.Jan 8 2020, 9:37 PM
MaskRay added a subscriber: merge_guards_bot.
MaskRay updated this revision to Diff 236962.Jan 8 2020, 9:43 PM

Improve tests

Unit tests: fail. 61321 tests passed, 1 failed and 737 were skipped.

failed: Clang.Driver/ppc-features.cpp

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Unit tests: pass. 61322 tests passed, 0 failed and 737 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

jhibbits accepted this revision.Jan 10 2020, 11:38 AM

Fine with me. I just wanted -target powerpcspe-... to work with D72014.

This revision is now accepted and ready to land.Jan 10 2020, 11:38 AM
This revision was automatically updated to reflect the committed changes.