This is an archive of the discontinued LLVM Phabricator instance.

[llvm-libc] Fix missing virtual destructor
ClosedPublic

Authored by gchatelet on Jan 6 2020, 4:33 AM.

Details

Summary

This patch adds a virtual destructor to the Command class.

Event Timeline

gchatelet created this revision.Jan 6 2020, 4:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2020, 4:33 AM
gchatelet updated this revision to Diff 236325.Jan 6 2020, 4:35 AM
  • Fix newline + remove =0
sivachandra accepted this revision.Jan 6 2020, 8:34 AM

Address the comment before landing.

libc/utils/HdrGen/Command.cpp
2

Add license header and this is good to go.

This revision is now accepted and ready to land.Jan 6 2020, 8:34 AM
gchatelet updated this revision to Diff 236380.Jan 6 2020, 8:37 AM
  • Address comments
gchatelet updated this revision to Diff 236381.Jan 6 2020, 8:38 AM
gchatelet marked an inline comment as done.
  • Fixed wrong description for the header
This revision was automatically updated to reflect the committed changes.