This is an archive of the discontinued LLVM Phabricator instance.

Differential D72253

[llvm-libc] Fix missing virtual destructor
ClosedPublic

Authored by gchatelet on Jan 6 2020, 4:33 AM.

Details

Reviewers
sivachandra
Commits
rG3e1f3b164cc0: [llvm-libc] Fix missing virtual destructor
Summary

This patch adds a virtual destructor to the Command class.

Diff Detail

Event Timeline

gchatelet created this revision.Jan 6 2020, 4:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2020, 4:33 AM
Herald added subscribers: libc-commits, MaskRay, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B43333: Diff 236324.Jan 6 2020, 4:34 AM
gchatelet updated this revision to Diff 236325.Jan 6 2020, 4:35 AM
  • Fix newline + remove =0
Harbormaster completed remote builds in B43334: Diff 236325.Jan 6 2020, 4:36 AM
sivachandra accepted this revision.Jan 6 2020, 8:34 AM

Address the comment before landing.

libc/utils/HdrGen/Command.cpp
1

Add license header and this is good to go.

This revision is now accepted and ready to land.Jan 6 2020, 8:34 AM
gchatelet updated this revision to Diff 236380.Jan 6 2020, 8:37 AM
  • Address comments
Harbormaster completed remote builds in B43347: Diff 236380.Jan 6 2020, 8:37 AM
gchatelet updated this revision to Diff 236381.Jan 6 2020, 8:38 AM
gchatelet marked an inline comment as done.
  • Fixed wrong description for the header
Harbormaster completed remote builds in B43348: Diff 236381.Jan 6 2020, 8:38 AM
gchatelet added a comment.Jan 6 2020, 8:40 AM

Thx !

Closed by commit rG3e1f3b164cc0: [llvm-libc] Fix missing virtual destructor (authored by gchatelet). · Explain WhyJan 6 2020, 8:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libc/
utils/
HdrGen/
1 line
2 lines
7 lines

Diff 236325

libc/utils/HdrGen/CMakeLists.txt

add_tablegen(libc-hdrgen llvm-libc add_tablegen(libc-hdrgen llvm-libc
Command.h Command.h
Command.cpp
Generator.cpp Generator.cpp
Generator.h Generator.h
IncludeFileCommand.cpp IncludeFileCommand.cpp
IncludeFileCommand.h IncludeFileCommand.h
Main.cpp Main.cpp
PublicAPICommand.cpp PublicAPICommand.cpp
PublicAPICommand.h PublicAPICommand.h
) )

libc/utils/HdrGen/Command.h

Show All 36 Lines public:
ErrorReporter(llvm::SMLoc L, llvm::SourceMgr &SM) : Loc(L), SrcMgr(SM) {} ErrorReporter(llvm::SMLoc L, llvm::SourceMgr &SM) : Loc(L), SrcMgr(SM) {}
void printFatalError(llvm::Twine Msg) const { void printFatalError(llvm::Twine Msg) const {
SrcMgr.PrintMessage(Loc, llvm::SourceMgr::DK_Error, Msg); SrcMgr.PrintMessage(Loc, llvm::SourceMgr::DK_Error, Msg);
std::exit(1); std::exit(1);
} }
}; };
virtual ~Command();
virtual void run(llvm::raw_ostream &OS, const ArgVector &Args, virtual void run(llvm::raw_ostream &OS, const ArgVector &Args,
llvm::StringRef StdHeader, llvm::RecordKeeper &Records, llvm::StringRef StdHeader, llvm::RecordKeeper &Records,
const ErrorReporter &Reporter) const = 0; const ErrorReporter &Reporter) const = 0;
}; };
} // namespace llvm_libc } // namespace llvm_libc
#endif // LLVM_LIBC_UTILS_HDRGEN_COMMAND_H #endif // LLVM_LIBC_UTILS_HDRGEN_COMMAND_H

libc/utils/HdrGen/Command.cpp

  • This file was added.
#include "Command.h"
sivachandraUnsubmitted
Done
ReplyInline Actions

Add license header and this is good to go.

sivachandra: Add license header and this is good to go.
namespace llvm_libc {
Command::~Command() {}
} // namespace llvm_libc