[test][ELF] Use CHECK-NEXT to properly check error messages

[jhenderson]

Summary

This is a follow up to D71759.

[dblaikie]

@MaskRay I know it's a bit quirky, but Phabricator doesn't send email to the list on status changes (like approvals) that contain no user-authored text, which makes it look like patches are being committed without approval (if you're just reading the mailing list). If you could write a little something ("Thanks", "Looks good", etc) whenever approving a patch, it'd help make sure the mailing list accurately reflects the state of patches - thanks!

[MaskRay]

In D72092#1945410, @dblaikie wrote:

@MaskRay I know it's a bit quirky, but Phabricator doesn't send email to the list on status changes (like approvals) that contain no user-authored text, which makes it look like patches are being committed without approval (if you're just reading the mailing list). If you could write a little something ("Thanks", "Looks good", etc) whenever approving a patch, it'd help make sure the mailing list accurately reflects the state of patches - thanks!

@dblaikie I actually read a similar comment from you to another person. Thanks for the reminder! To prevent me from forgetting, I created a Tampermonkey script:

const select = document.querySelector('.aphront-form-input > select')
if (select)
  select.onchange = function() {
    const accept = select.querySelector('option[value=accept]')
    if (accept && accept.disabled) {
      const comment = document.querySelector('.remarkup-assist-textarea')
      if (comment && comment.value.length == 0) {
        const words = ['LGTM.', 'Thanks!', 'Looks great!']
        comment.value = words[~~(Math.random()*words.length)]+' '
        comment.focus()
      }
    }
  }

[dblaikie]

In D72092#1945523, @MaskRay wrote:

In D72092#1945410, @dblaikie wrote:

@MaskRay I know it's a bit quirky, but Phabricator doesn't send email to the list on status changes (like approvals) that contain no user-authored text, which makes it look like patches are being committed without approval (if you're just reading the mailing list). If you could write a little something ("Thanks", "Looks good", etc) whenever approving a patch, it'd help make sure the mailing list accurately reflects the state of patches - thanks!

@dblaikie I actually read a similar comment from you to another person. Thanks for the reminder! To prevent me from forgetting, I created a Tampermonkey script:

const select = document.querySelector('.aphront-form-input > select')
if (select)
  select.onchange = function() {
    const accept = select.querySelector('option[value=accept]')
    if (accept && accept.disabled) {
      const comment = document.querySelector('.remarkup-assist-textarea')
      if (comment && comment.value.length == 0) {
        const words = ['LGTM.', 'Thanks!', 'Looks great!']
        comment.value = words[~~(Math.random()*words.length)]+' '
        comment.focus()
      }
    }
  }

oh, nifty! Thanks!

lld/test/ELF/undef.s

 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/undef.s -o %t2.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/undef-debug.s -o %t3.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/undef-bad-debug.s -o %t4.o
 # RUN: rm -f %t2.a
 # RUN: llvm-ar rc %t2.a %t2.o
 # RUN: not ld.lld %t.o %t2.a %t3.o %t4.o -o %t.exe 2>&1 \
 # RUN:   | FileCheck %s --implicit-check-not="error:" --implicit-check-not="warning:"
 # RUN: not ld.lld -pie %t.o %t2.a %t3.o %t4.o -o %t.exe 2>&1 \
 # RUN:   | FileCheck %s --implicit-check-not="error:" --implicit-check-not="warning:"
 
-# CHECK: error: undefined symbol: foo
-# CHECK: >>> referenced by undef.s
-# CHECK:                   {{.*}}:(.text+0x1)
+# CHECK:      error: undefined symbol: foo
+# CHECK-NEXT: >>> referenced by undef.s
+# CHECK-NEXT:                   {{.*}}:(.text+0x1)
 
-# CHECK: error: undefined symbol: bar
-# CHECK: >>> referenced by undef.s
-# CHECK: >>>               {{.*}}:(.text+0x6)
+# CHECK:      error: undefined symbol: bar
+# CHECK-NEXT: >>> referenced by undef.s
+# CHECK-NEXT: >>>               {{.*}}:(.text+0x6)
 
-# CHECK: error: undefined symbol: foo(int)
-# CHECK: >>> referenced by undef.s
-# CHECK: >>>               {{.*}}:(.text+0x10)
+# CHECK:      error: undefined symbol: foo(int)
+# CHECK-NEXT: >>> referenced by undef.s
+# CHECK-NEXT: >>>               {{.*}}:(.text+0x10)
 
-# CHECK: error: undefined symbol: vtable for Foo
-# CHECK: the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction)
+# CHECK:      error: undefined symbol: vtable for Foo
+# CHECK-NEXT: >>> referenced by undef.s
+# CHECK-NEXT: >>>               {{.*}}:(.text+0x15)
+# CHECK-NEXT: the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction)
 
 # Check that this symbol isn't demangled
 
-# CHECK: error: undefined symbol: __Z3fooi
-# CHECK: >>> referenced by undef.s
-# CHECK: >>>               {{.*}}:(.text+0x1A)
+# CHECK:      error: undefined symbol: __Z3fooi
+# CHECK-NEXT: >>> referenced by undef.s
+# CHECK-NEXT: >>>               {{.*}}:(.text+0x1A)
 
-# CHECK: error: undefined symbol: zed2
-# CHECK: >>> referenced by {{.*}}.o:(.text+0x0) in archive {{.*}}2.a
+# CHECK:      error: undefined symbol: zed2
+# CHECK-NEXT: >>> referenced by {{.*}}.o:(.text+0x0) in archive {{.*}}2.a
 
-# CHECK: error: undefined symbol: zed3
-# CHECK: >>> referenced by undef-debug.s:3 (dir{{/|\\}}undef-debug.s:3)
-# CHECK: >>>               {{.*}}.o:(.text+0x0)
+# CHECK:      error: undefined symbol: zed3
+# CHECK-NEXT: >>> referenced by undef-debug.s:3 (dir{{/|\\}}undef-debug.s:3)
+# CHECK-NEXT: >>>               {{.*}}.o:(.text+0x0)
 
-# CHECK: error: undefined symbol: zed4
-# CHECK: >>> referenced by undef-debug.s:7 (dir{{/|\\}}undef-debug.s:7)
-# CHECK: >>>               {{.*}}.o:(.text.1+0x0)
+# CHECK:      error: undefined symbol: zed4
+# CHECK-NEXT: >>> referenced by undef-debug.s:7 (dir{{/|\\}}undef-debug.s:7)
+# CHECK-NEXT: >>>               {{.*}}.o:(.text.1+0x0)
 
-# CHECK: error: undefined symbol: zed5
-# CHECK: >>> referenced by undef-debug.s:11 (dir{{/|\\}}undef-debug.s:11)
-# CHECK: >>>               {{.*}}.o:(.text.2+0x0)
+# CHECK:      error: undefined symbol: zed5
+# CHECK-NEXT: >>> referenced by undef-debug.s:11 (dir{{/|\\}}undef-debug.s:11)
+# CHECK-NEXT: >>>               {{.*}}.o:(.text.2+0x0)
 
 # Show that all line table problems are mentioned as soon as the object's line information
 # is requested, even if that particular part of the line information is not currently required.
 # Also show that the warnings are only printed once.
-# CHECK: warning: parsing line table prologue at 0x00000000 should have ended at 0x00000038 but it ended at 0x00000037
-# CHECK: warning: last sequence in debug line table is not terminated!
-# CHECK: error: undefined symbol: zed6a
-# CHECK: >>> referenced by {{.*}}tmp4.o:(.text+0x0)
-# CHECK: error: undefined symbol: zed6b
-# CHECK: >>> referenced by {{.*}}tmp4.o:(.text+0x8)
+# CHECK:      warning: parsing line table prologue at 0x00000000 should have ended at 0x00000038 but it ended at 0x00000037
+# CHECK-NEXT: warning: last sequence in debug line table is not terminated!
+# CHECK:      error: undefined symbol: zed6a
+# CHECK-NEXT: >>> referenced by {{.*}}tmp4.o:(.text+0x0)
+# CHECK:      error: undefined symbol: zed6b
+# CHECK-NEXT: >>> referenced by {{.*}}tmp4.o:(.text+0x8)
 
 # Show that a problem with one line table's information doesn't affect getting information from
 # a different one in the same object.
-# CHECK: error: undefined symbol: zed7
-# CHECK: >>> referenced by undef-bad-debug2.s:11 (dir2{{/|\\}}undef-bad-debug2.s:11)
-# CHECK: >>>               {{.*}}tmp4.o:(.text+0x10)
+# CHECK:      error: undefined symbol: zed7
+# CHECK-NEXT: >>> referenced by undef-bad-debug2.s:11 (dir2{{/|\\}}undef-bad-debug2.s:11)
+# CHECK-NEXT: >>>               {{.*}}tmp4.o:(.text+0x10)
 
 # RUN: not ld.lld %t.o %t2.a -o %t.exe -no-demangle 2>&1 | \
 # RUN:   FileCheck -check-prefix=NO-DEMANGLE %s
 # NO-DEMANGLE: error: undefined symbol: _Z3fooi
 
 .file "undef.s"
 
   .globl _start
 _start:
   call foo
   call bar
   call zed1
   call _Z3fooi
   call _ZTV3Foo
   call __Z3fooi