[test][ELF] Verify debug line corruption messages are printed once

[jhenderson]

Summary

LLD warns if it encounters malformed debug data when parsing line information for an undefined reference. We only want to warn once.

This patch adds additional checking to make sure the warnings are printed only once, both for variables within the same program and variables in later line programs.

Related to D71702 which will touch this file.

[grimar]

LGTM

[MaskRay]

lld/test/ELF/undef.s

55–57

Add -NEXT: by the way?

[jhenderson]

lld/test/ELF/undef.s

55–57

I'll do this in a separate follow-up, as the rest of the checks in this file are not -NEXT currently.

lld/test/ELF/Inputs/undef-bad-debug.s

 .section .text,"ax"
 sym:
-    .quad zed6
+    .quad zed6a
 sym2:
+    .quad zed6b
+sym3:
     .quad zed7
 
 .section .debug_line,"",@progbits
 .Lunit:
     .long .Lunit_end - .Lunit_start # unit length
 .Lunit_start:
     .short 4                        # version
     .long .Lprologue_end - .Lprologue_start # prologue length

 .Lprologue_end:
     .byte 0, 9, 2                   # DW_LNE_set_address
     .quad sym
     .byte 3                         # DW_LNS_advance_line
     .byte 10
     .byte 1                         # DW_LNS_copy
     .byte 2                         # DW_LNS_advance_pc
     .byte 8
+    .byte 0, 9, 2                   # DW_LNE_set_address
+    .quad sym2
+    .byte 3                         # DW_LNS_advance_line
+    .byte 10
+    .byte 1                         # DW_LNS_copy
+    .byte 2                         # DW_LNS_advance_pc
+    .byte 8
     .byte 0, 1, 1                   # DW_LNE_end_sequence
 .Lunit_end:
 
 .Lunit2:
     .long .Lunit2_end - .Lunit2_start # unit length
 .Lunit2_start:
     .short 4                        # version
     .long .Lprologue2_end - .Lprologue2_start # prologue length
 .Lprologue2_start:
     .byte 1                         # minimum instruction length
     .byte 1                         # maximum operatiosn per instruction
     .byte 1                         # default is_stmt
     .byte -5                        # line base
     .byte 14                        # line range
     .byte 13                        # opcode base
     .byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # standard opcode lengths
     .asciz "dir2"                   # include directories
     .byte 0
     .asciz "undef-bad-debug2.s"     # file names
     .byte 1, 0, 0
     .byte 0
 .Lprologue2_end:
     .byte 0, 9, 2                   # DW_LNE_set_address
-    .quad sym2
+    .quad sym3
     .byte 3                         # DW_LNS_advance_line
     .byte 10
     .byte 1                         # DW_LNS_copy
     .byte 2                         # DW_LNS_advance_pc
     .byte 8
     .byte 0, 1, 1                   # DW_LNE_end_sequence
     .byte 0, 9, 2                   # DW_LNE_set_address
     .quad 0x0badbeef
.section .debug_info,"",@progbits
     .long   .Lcu_end - .Lcu_start   # Length of Unit
 .Lcu_start:
     .short  4                       # DWARF version number
     .long   .Lsection_abbrev        # Offset Into Abbrev. Section
     .byte   8                       # Address Size (in bytes)
     .byte   1                       # Abbrev [1] 0xb:0x79 DW_TAG_compile_unit
     .long   .Lunit                  # DW_AT_stmt_list
     .byte   2                       # Abbrev [2] 0x2a:0x15 DW_TAG_variable
-    .long   .Linfo_string           # DW_AT_name
+    .long   .Linfo_string0          # DW_AT_name
                                         # DW_AT_external
     .byte   1                       # DW_AT_decl_file
     .byte   3                       # DW_AT_decl_line
+    .byte   2                       # Abbrev [2] 0x2a:0x15 DW_TAG_variable
+    .long   .Linfo_string1          # DW_AT_name
+                                        # DW_AT_external
+    .byte   1                       # DW_AT_decl_file
+    .byte   6                       # DW_AT_decl_line
     .byte   0                       # End Of Children Mark
 .Lcu_end:
 
     .long   .Lcu2_end - .Lcu2_start # Length of Unit
 .Lcu2_start:
     .short  4                       # DWARF version number
     .long   .Lsection_abbrev        # Offset Into Abbrev. Section
     .byte   8                       # Address Size (in bytes)
.Lsection_abbrev:
     .byte   11                      # DW_FORM_data1
     .byte   59                      # DW_AT_decl_line
     .byte   11                      # DW_FORM_data1
     .byte   0                       # EOM(1)
     .byte   0                       # EOM(2)
     .byte   0                       # EOM(3)
 
 .section .debug_str,"MS",@progbits,1
-.Linfo_string:
+.Linfo_string0:
     .asciz "sym"
-.Linfo2_string:
+.Linfo_string1:
     .asciz "sym2"
+.Linfo2_string:
+    .asciz "sym3"

lld/test/ELF/undef.s

 # REQUIRES: x86
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/undef.s -o %t2.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/undef-debug.s -o %t3.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %p/Inputs/undef-bad-debug.s -o %t4.o
 # RUN: rm -f %t2.a
 # RUN: llvm-ar rc %t2.a %t2.o
-# RUN: not ld.lld %t.o %t2.a %t3.o %t4.o -o %t.exe 2>&1 | FileCheck %s
-# RUN: not ld.lld -pie %t.o %t2.a %t3.o %t4.o -o %t.exe 2>&1 | FileCheck %s
+# RUN: not ld.lld %t.o %t2.a %t3.o %t4.o -o %t.exe 2>&1 \
+# RUN:   | FileCheck %s --implicit-check-not="error:" --implicit-check-not="warning:"
+# RUN: not ld.lld -pie %t.o %t2.a %t3.o %t4.o -o %t.exe 2>&1 \
+# RUN:   | FileCheck %s --implicit-check-not="error:" --implicit-check-not="warning:"
 
 # CHECK: error: undefined symbol: foo
 # CHECK: >>> referenced by undef.s
 # CHECK:                   {{.*}}:(.text+0x1)
 
 # CHECK: error: undefined symbol: bar
 # CHECK: >>> referenced by undef.s
 # CHECK: >>>               {{.*}}:(.text+0x6)

 # CHECK: >>>               {{.*}}.o:(.text.1+0x0)
 
 # CHECK: error: undefined symbol: zed5
 # CHECK: >>> referenced by undef-debug.s:11 (dir{{/|\\}}undef-debug.s:11)
 # CHECK: >>>               {{.*}}.o:(.text.2+0x0)
 
 # Show that all line table problems are mentioned as soon as the object's line information
 # is requested, even if that particular part of the line information is not currently required.
+# Also show that the warnings are only printed once.
 # CHECK: warning: parsing line table prologue at 0x00000000 should have ended at 0x00000038 but it ended at 0x00000037
 # CHECK: warning: last sequence in debug line table is not terminated!
-# CHECK: error: undefined symbol: zed6
+# CHECK: error: undefined symbol: zed6a
 # CHECK: >>> referenced by {{.*}}tmp4.o:(.text+0x0)
+# CHECK: error: undefined symbol: zed6b
+# CHECK: >>> referenced by {{.*}}tmp4.o:(.text+0x8)
 
 # Show that a problem with one line table's information doesn't affect getting information from
 # a different one in the same object.
 # CHECK: error: undefined symbol: zed7
 # CHECK: >>> referenced by undef-bad-debug2.s:11 (dir2{{/|\\}}undef-bad-debug2.s:11)
-# CHECK: >>>               {{.*}}tmp4.o:(.text+0x8)
+# CHECK: >>>               {{.*}}tmp4.o:(.text+0x10)
 
 # RUN: not ld.lld %t.o %t2.a -o %t.exe -no-demangle 2>&1 | \
 # RUN:   FileCheck -check-prefix=NO-DEMANGLE %s
 # NO-DEMANGLE: error: undefined symbol: _Z3fooi
 
 .file "undef.s"
 
   .globl _start
 _start:
   call foo
   call bar
   call zed1
   call _Z3fooi
   call _ZTV3Foo
   call __Z3fooi