Page MenuHomePhabricator

[NewPM] Fix -lto-debug-pass-manager in LLD.
AcceptedPublic

Authored by hghwng on Dec 29 2019, 8:59 PM.

Details

Reviewers
davide
pcc

Diff Detail

Event Timeline

hghwng created this revision.Dec 29 2019, 8:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 29 2019, 8:59 PM
Jim added a subscriber: Jim.Dec 30 2019, 9:57 PM
hghwng added a reviewer: pcc.Jan 1 2020, 4:56 AM

Looks reasonable.

llvm/lib/LTO/LTOBackend.cpp
257

auto->Error since you are touching this line.

hghwng added inline comments.Jan 3 2020, 6:00 PM
llvm/lib/LTO/LTOBackend.cpp
257

Could you please elaborate it a bit?

davide accepted this revision.Jan 6 2020, 1:12 PM

LGTM.

llvm/lib/LTO/LTOBackend.cpp
257

I think he's saying you should spell explicitly Error Err = ....

This revision is now accepted and ready to land.Jan 6 2020, 1:12 PM