tools/clang/tools/extra
has become
clang-tools-extra
which was not updated in all docs.
Paths
| Differential D71982
[docs] Update path to clang-tools-extra ClosedPublic Authored by AlexanderLanin on Dec 29 2019, 5:20 PM.
Details Summary
has become
which was not updated in all docs.
Diff Detail
Event TimelineEugene.Zelenko added reviewers: alexfh, aaron.ballman, ilya-biryukov, juliehockett.Dec 29 2019, 9:58 PM Comment Actions Hi,
Source of problem:
But then upload fails:
https://llvm.org/docs/GettingStarted.html#sending-patches just casually mentions git show and git format-patch without telling anything about options to be used. Assuming 'git show HEAD -U999999' is the one and only correct way? 'git diff HEAD~1 -U999999' seems to work ok also.
AlexanderLanin added inline comments.
Comment Actions As you mention, we're already inconsistent with how we designate where the repo lives on disk, so I'm fine with landing this as-is and making the root part of the path consistent in a follow-up. LGTM, with the "getting started" changes pulled out.
This revision is now accepted and ready to land.Jan 1 2020, 12:45 PM AlexanderLanin marked an inline comment as done. Comment ActionsRemoved change in hacking page as discussed. Comment Actions @AlexanderLanin Closed by commit rG8188c998ffa4: [docs] Update path to clang-tools-extra (authored by AlexanderLanin, committed by Jim). · Explain WhyJan 2 2020, 3:30 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 235846 clang-tools-extra/docs/clang-include-fixer.rst
clang-tools-extra/docs/clang-tidy/Contributing.rst
clang-tools-extra/docs/pp-trace.rst
|
I am no sure that "llvm/clang-tools-extra" should be replaced as "llvm-project/clang-tools-extra".
Maybe someone would confuse with "llvm", "llvm-project" and "llvm-project/llvm"