This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objdump][llvm-readobj] - Refactor dynamic tags dumping.
AbandonedPublic

Authored by grimar on Dec 20 2019, 2:48 AM.

Details

Summary

Some times we have no space between a long dynamic tag and
it's value. In this patch I suggest to compute the length
of the padding on the fly.
I've also got rid of some code duplication we had and improved
test cases.

Diff Detail

Event Timeline

grimar created this revision.Dec 20 2019, 2:48 AM

This change isn't a refactor, and it seems to cover multiple different issues. I think it needs breaking up:

  1. Fix the spacing.
  2. Improve the printing of unknown tags (I assume the GNU style matches GNU readelf's output?).
  3. Improve the testing.
  4. Any other refactor (i.e. no functional changes) to support the above.

I'm happy for these to be in any order that makes sense, but as things stand, I don't feel confident in reviewing it.

grimar abandoned this revision.Dec 20 2019, 7:40 AM

I'll split into multiple patches.