Some times we have no space between a long dynamic tag and
it's value. In this patch I suggest to compute the length
of the padding on the fly.
I've also got rid of some code duplication we had and improved
test cases.
Details
Details
- Reviewers
jhenderson MaskRay • espindola
Diff Detail
Diff Detail
Event Timeline
Comment Actions
This change isn't a refactor, and it seems to cover multiple different issues. I think it needs breaking up:
- Fix the spacing.
- Improve the printing of unknown tags (I assume the GNU style matches GNU readelf's output?).
- Improve the testing.
- Any other refactor (i.e. no functional changes) to support the above.
I'm happy for these to be in any order that makes sense, but as things stand, I don't feel confident in reviewing it.