This is an archive of the discontinued LLVM Phabricator instance.

Differential D71670

Support powerpc when builing without init_array.
ClosedPublic

Authored by saugustine on Dec 18 2019, 11:17 AM.

Details

Reviewers
jgorbe
rdhindsa
Commits
rG5789e83dedb9: Support powerpc when builing without init_array.
Summary

Also add an error case when targetting an unimplement architecture.

Diff Detail

Event Timeline

saugustine created this revision.Dec 18 2019, 11:17 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 18 2019, 11:17 AM
Herald added subscribers: llvm-commits, Restricted Project, shchenz and 2 others. · View Herald Transcript
saugustine added reviewers: jgorbe, rdhindsa.Dec 18 2019, 11:18 AM
Herald added a subscriber: • wuzish. · View Herald TranscriptDec 18 2019, 11:18 AM
Harbormaster completed remote builds in B42752: Diff 234585.Dec 18 2019, 11:26 AM
rdhindsa accepted this revision.Dec 18 2019, 11:35 AM

LGTM

This revision is now accepted and ready to land.Dec 18 2019, 11:35 AM
saugustine closed this revision.Dec 18 2019, 1:38 PM

Landed as 5789e83dedb97588ad75cca36d01ba6c5142d6d3

gribozavr2 added a subscriber: gribozavr2.Dec 19 2019, 2:36 AM

Sorry, I reverted this change because it broke the build on aarch64. https://github.com/llvm/llvm-project/commit/0109efe7513dd984cf67d102ce5179a5b24d58f6

Revision Contents

PathSize
compiler-rt/
lib/
crt/
20 lines

Diff 234585

compiler-rt/lib/crt/crtbegin.c

Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Lines
#if defined(__i386__) || defined(__x86_64__) #if defined(__i386__) || defined(__x86_64__)
__asm__(".pushsection .init,\"ax\",@progbits\n\t" __asm__(".pushsection .init,\"ax\",@progbits\n\t"
"call " __USER_LABEL_PREFIX__ "__do_init\n\t" "call " __USER_LABEL_PREFIX__ "__do_init\n\t"
".popsection"); ".popsection");
#elif defined(__arm__) #elif defined(__arm__)
__asm__(".pushsection .init,\"ax\",%progbits\n\t" __asm__(".pushsection .init,\"ax\",%progbits\n\t"
"bl " __USER_LABEL_PREFIX__ "__do_init\n\t" "bl " __USER_LABEL_PREFIX__ "__do_init\n\t"
".popsection"); ".popsection");
#elif defined(__powerpc__) || defined(__powerpc64__)
__asm__(".pushsection .init,\"ax\",@progbits\n\t"
"bl " __USER_LABEL_PREFIX__ "__do_init\n\t"
"nop\n\t"
".popsection");
#else
#error "crtbegin without .init_fini array unimplemented for this architecture"
#endif // defined(various architectures)
#endif // CRT_HAS_INITFINI_ARRAY #endif // CRT_HAS_INITFINI_ARRAY
#endif
#ifndef CRT_HAS_INITFINI_ARRAY #ifndef CRT_HAS_INITFINI_ARRAY
static fp __DTOR_LIST__[] static fp __DTOR_LIST__[]
__attribute__((section(".dtors"), aligned(sizeof(fp)))) = {(fp)-1}; __attribute__((section(".dtors"), aligned(sizeof(fp)))) = {(fp)-1};
extern fp __DTOR_LIST_END__[]; extern fp __DTOR_LIST_END__[];
#endif #endif
static void __attribute__((used)) __do_fini() { static void __attribute__((used)) __do_fini() {
Show All 22 Lines
#if defined(__i386__) || defined(__x86_64__) #if defined(__i386__) || defined(__x86_64__)
__asm__(".pushsection .fini,\"ax\",@progbits\n\t" __asm__(".pushsection .fini,\"ax\",@progbits\n\t"
"call " __USER_LABEL_PREFIX__ "__do_fini\n\t" "call " __USER_LABEL_PREFIX__ "__do_fini\n\t"
".popsection"); ".popsection");
#elif defined(__arm__) #elif defined(__arm__)
__asm__(".pushsection .fini,\"ax\",%progbits\n\t" __asm__(".pushsection .fini,\"ax\",%progbits\n\t"
"bl " __USER_LABEL_PREFIX__ "__do_fini\n\t" "bl " __USER_LABEL_PREFIX__ "__do_fini\n\t"
".popsection"); ".popsection");
#endif #elif defined(__powerpc__) || defined(__powerpc64__)
__asm__(".pushsection .fini,\"ax\",@progbits\n\t"
"bl " __USER_LABEL_PREFIX__ "__do_fini\n\t"
"nop\n\t"
".popsection");
#else
#error "crtbegin without .init_fini array unimplemented for this architecture"
#endif // defined(various architectures)
#endif // CRT_HAS_INIT_FINI_ARRAY #endif // CRT_HAS_INIT_FINI_ARRAY