Page MenuHomePhabricator

[llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm
ClosedPublic

Authored by mstojanovic on Dec 18 2019, 9:01 AM.

Details

Summary

The inconsistency caused uops mode to fail on an older version of libpfm since the dispatched_port was added as an alias for executed_port only after v4.6.0 of libpfm.

Diff Detail

Event Timeline

mstojanovic created this revision.Dec 18 2019, 9:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2019, 9:01 AM

That is weird. If I understand the intel doc correctly, both these names refer to the same event (EventSel=A1H, UMask=01H). I have a haswell machine and dispatched worked (but I patched your change and I get the exact same results, which is to be expected given that the event is the same). What version of libpfm do you have ? I've seen both work on`4.10.1+git14-g815ff28-1`.

I have version 4.4.0+git47-g71166e2-1 so yes, I think this is the problem since the alias was added only after v4.6.0.

mstojanovic retitled this revision from [llvm-exegesis] Fix pfm counter names for Haswell to [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.Dec 19 2019, 3:06 AM
mstojanovic edited the summary of this revision. (Show Details)
courbet accepted this revision.Dec 19 2019, 3:38 AM

OK great.

This revision is now accepted and ready to land.Dec 19 2019, 3:38 AM
This revision was automatically updated to reflect the committed changes.