This is an archive of the discontinued LLVM Phabricator instance.

Differential D71665

[llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm
ClosedPublic

Authored by mstojanovic on Dec 18 2019, 9:01 AM.

Details

Reviewers
courbet
gchatelet
petarj
Commits
rGd005df4c1656: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm
Summary

The inconsistency caused uops mode to fail on an older version of libpfm since the dispatched_port was added as an alias for executed_port only after v4.6.0 of libpfm.

Diff Detail

Event Timeline

mstojanovic created this revision.Dec 18 2019, 9:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2019, 9:01 AM
Herald added subscribers: tschuett, hiraditya. · View Herald Transcript
mstojanovic added a reviewer: petarj.Dec 18 2019, 9:52 AM
courbet added a comment.Dec 18 2019, 11:51 PM

That is weird. If I understand the intel doc correctly, both these names refer to the same event (EventSel=A1H, UMask=01H). I have a haswell machine and dispatched worked (but I patched your change and I get the exact same results, which is to be expected given that the event is the same). What version of libpfm do you have ? I've seen both work on`4.10.1+git14-g815ff28-1`.

mstojanovic added a comment.Dec 19 2019, 2:59 AM

I have version 4.4.0+git47-g71166e2-1 so yes, I think this is the problem since the alias was added only after v4.6.0.

mstojanovic retitled this revision from [llvm-exegesis] Fix pfm counter names for Haswell to [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm.Dec 19 2019, 3:06 AM
mstojanovic edited the summary of this revision. (Show Details)
courbet accepted this revision.Dec 19 2019, 3:38 AM

OK great.

This revision is now accepted and ready to land.Dec 19 2019, 3:38 AM
Closed by commit rGd005df4c1656: [llvm-exegesis] Fix pfm counter names for Haswell for older versions of libpfm (authored by mstojanovic). · Explain WhyDec 19 2019, 4:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
16 lines

Diff 234696

llvm/lib/Target/X86/X86PfmCounters.td

Show First 20 Lines • Show All 75 Lines • ▼ Show 20 Lines
} }
def : PfmCountersBinding<"sandybridge", SandyBridgePfmCounters>; def : PfmCountersBinding<"sandybridge", SandyBridgePfmCounters>;
def : PfmCountersBinding<"ivybridge", SandyBridgePfmCounters>; def : PfmCountersBinding<"ivybridge", SandyBridgePfmCounters>;
def HaswellPfmCounters : ProcPfmCounters { def HaswellPfmCounters : ProcPfmCounters {
let CycleCounter = UnhaltedCoreCyclesPfmCounter; let CycleCounter = UnhaltedCoreCyclesPfmCounter;
let UopsCounter = UopsIssuedPfmCounter; let UopsCounter = UopsIssuedPfmCounter;
let IssueCounters = [ let IssueCounters = [
PfmIssueCounter<"HWPort0", "uops_dispatched_port:port_0">, PfmIssueCounter<"HWPort0", "uops_executed_port:port_0">,
PfmIssueCounter<"HWPort1", "uops_dispatched_port:port_1">, PfmIssueCounter<"HWPort1", "uops_executed_port:port_1">,
PfmIssueCounter<"HWPort2", "uops_dispatched_port:port_2">, PfmIssueCounter<"HWPort2", "uops_executed_port:port_2">,
PfmIssueCounter<"HWPort3", "uops_dispatched_port:port_3">, PfmIssueCounter<"HWPort3", "uops_executed_port:port_3">,
PfmIssueCounter<"HWPort4", "uops_dispatched_port:port_4">, PfmIssueCounter<"HWPort4", "uops_executed_port:port_4">,
PfmIssueCounter<"HWPort5", "uops_dispatched_port:port_5">, PfmIssueCounter<"HWPort5", "uops_executed_port:port_5">,
PfmIssueCounter<"HWPort6", "uops_dispatched_port:port_6">, PfmIssueCounter<"HWPort6", "uops_executed_port:port_6">,
PfmIssueCounter<"HWPort7", "uops_dispatched_port:port_7"> PfmIssueCounter<"HWPort7", "uops_executed_port:port_7">
]; ];
} }
def : PfmCountersBinding<"haswell", HaswellPfmCounters>; def : PfmCountersBinding<"haswell", HaswellPfmCounters>;
def BroadwellPfmCounters : ProcPfmCounters { def BroadwellPfmCounters : ProcPfmCounters {
let CycleCounter = UnhaltedCoreCyclesPfmCounter; let CycleCounter = UnhaltedCoreCyclesPfmCounter;
let UopsCounter = UopsIssuedPfmCounter; let UopsCounter = UopsIssuedPfmCounter;
let IssueCounters = [ let IssueCounters = [
▲ Show 20 Lines • Show All 126 Lines • Show Last 20 Lines