Page MenuHomePhabricator

[clangd] Replace shortenNamespace with getQualification
ClosedPublic

Authored by kadircet on Dec 18 2019, 2:24 AM.

Diff Detail

Event Timeline

kadircet created this revision.Dec 18 2019, 2:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2019, 2:24 AM

Unit tests: fail. 60978 tests passed, 1 failed and 727 were skipped.

failed: lit.lit/shtest-format.py

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

ilya-biryukov added inline comments.Dec 18 2019, 7:29 AM
clang-tools-extra/clangd/AST.cpp
307

Why not use explicitTargetReferences here? This should handle typedefs (and potentially other things) as well.
I'm not sure we can tests those, as auto might have all typedefs stripped of, though

kadircet updated this revision to Diff 234564.Dec 18 2019, 9:47 AM
  • Use explicitTargetReferences
  • Added some testing

Unit tests: unknown.

clang-tidy: unknown.

clang-format: unknown.

Build artifacts: diff.json, console-log.txt

ilya-biryukov accepted this revision.Thu, Jan 2, 6:12 AM

LGTM

clang-tools-extra/clangd/AST.cpp
307

This is such a terrible hack... Could you put a FIXME mentioning this should be done when printing names of the underlying decls instead?

This revision is now accepted and ready to land.Thu, Jan 2, 6:12 AM
This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.