This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add strict fma support
ClosedPublic

Authored by pengfei on Dec 17 2019, 5:31 AM.

Details

Summary

Add strict fma support

Diff Detail

Event Timeline

pengfei created this revision.Dec 17 2019, 5:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2019, 5:31 AM
craig.topper added inline comments.Dec 17 2019, 11:06 AM
llvm/lib/Target/X86/X86InstrFragmentsSIMD.td
498

I'd prefer we call this X86any_fmadd and update the users. That will make things more consistent.

llvm/test/CodeGen/X86/fp-strict-scalar.ll
585

The AVX1 check lines seem to be missing? Use the update script

llvm/test/CodeGen/X86/vec-strict-128.ll
224

Use the script

llvm/test/CodeGen/X86/vec-strict-256.ll
161

Use the script

llvm/test/CodeGen/X86/vec-strict-512.ll
156

This was not generated with the update_llc_test_checks.py script, regenerate it.

pengfei updated this revision to Diff 234438.Dec 17 2019, 6:02 PM

Address review comments.

pengfei marked 5 inline comments as done.Dec 17 2019, 6:05 PM
This revision is now accepted and ready to land.Dec 17 2019, 6:45 PM
This revision was automatically updated to reflect the committed changes.