[clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

[arphaman]

Summary

This patch adds a test case that verifies that -fmodules -fimplicit-modules work in Clangd when building the AST for Objective-C sources.

I based it on the test case attached to https://github.com/clangd/clangd/issues/198. I'm still looking into https://github.com/clangd/clangd/issues/198, but it might be unrelated to -fimplicit-modules support.

[kadircet]

Can we add a unit test instead of(or in addition to) this one?

I suppose it should be easy to right one using TestTU with ExtraArgs and AdditionalFiles

[ilya-biryukov]

+1, please add a unit test instead.
We prefer to keep the number of lit tests in clangd minimal. They're mostly testing the LSP layer and other things which are hard to unit-test. -fimplicit-modules does not seem to be one of these things.

[sammccall]

We do now have tests in unittests/ModulesTests.cpp that likely covers at least part of this?

clang-tools-extra/clangd/test/Inputs/implicit-modules/MyModule.h

+#import "hdr.h"

clang-tools-extra/clangd/test/Inputs/implicit-modules/compile_commands.json

+[{
+  "directory": "DIRECTORY",
+  "command": "clang -c implicit-modules.m -I DIRECTORY -fmodules -fimplicit-modules",
+  "file": "DIRECTORY/implicit-modules.m"
+}]

clang-tools-extra/clangd/test/Inputs/implicit-modules/hdr.h

+char foo(int x, int y);

clang-tools-extra/clangd/test/Inputs/implicit-modules/implicit-modules.m

+@import MyModule;
+
+int main() {
+  void *_ = foo(1, 2);
+  return foo(1, 2);
+}

clang-tools-extra/clangd/test/Inputs/implicit-modules/module.modulemap

+module MyModule {
+    umbrella header "MyModule.h"
+
+    export *
+    module * { export * }
+}
 No newline at end of file

clang-tools-extra/clangd/test/Inputs/implicit-modules/open.jsonrpc

+{
+  "jsonrpc": "2.0",
+  "id": 0,
+  "method": "initialize",
+  "params": {
+    "processId": 123,
+    "rootPath": "clangd",
+    "capabilities": {},
+    "trace": "off"
+  }
+}
+---
+{
+  "jsonrpc": "2.0",
+  "method": "textDocument/didOpen",
+  "params": {
+    "textDocument": {
+      "uri": "file://DIRECTORY/implicit-modules.m",
+      "languageId": "objective-c",
+      "version": 1,
+      "text": "@import MyModule;\n\nint main(){\nvoid *_ = foo(1, 2);\nreturn foo(1, 2);\n}"
+    }
+  }
+}
+---
+{
+  "jsonrpc": "2.0",
+  "id": 1,
+  "method": "sync",
+  "params": null
+}
+# CHECK: "diagnostics": [
+# CHECK: {
+# CHECK:     "code": "-Wint-conversion",
+# CHECK:     "message": "Incompatible integer to pointer conversion initializing 'void *' with an expression of type 'char'",
+# CHECK:     "range": {
+# CHECK:       "end": {
+# CHECK:         "character": 7,
+# CHECK:         "line": 3
+# CHECK:       },
+# CHECK:       "start": {
+# CHECK:         "character": 6,
+# CHECK:         "line": 3
+# CHECK:       }
+# CHECK:     },
+# CHECK:     "severity": 2,
+# CHECK:     "source": "clang"
+# CHECK: }
+---
+{"jsonrpc":"2.0","id":3,"method":"shutdown"}
+---
+{"jsonrpc":"2.0","method":"exit"}

clang-tools-extra/clangd/test/implicit-modules.test

+# We need to splice paths into file:// URIs for this test.
+# UNSUPPORTED: windows-msvc
+
+# Use a copy of inputs, as we'll mutate it (as will the background index).
+# RUN: rm -rf %t
+# RUN: cp -r %S/Inputs/implicit-modules %t
+# Need to embed the correct temp path in the actual JSON-RPC requests.
+# RUN: sed -i -e "s|DIRECTORY|%t|" %t/open.jsonrpc
+# RUN: sed -i -e "s|DIRECTORY|%t|" %t/compile_commands.json
+
+# RUN: clangd -lit-test < %t/open.jsonrpc | FileCheck %t/open.jsonrpc