Page MenuHomePhabricator

[lit] Fix internal diff newlines for -w/-b
ClosedPublic

Authored by jdenny on Dec 16 2019, 3:36 PM.

Details

Summary

For example, without this patch:

$ python $LIT_BUILTINS/diff.py -b foo.txt bar.txt
*** /tmp/foo.txt
--- /tmp/bar.txt
***************
*** 1,2 ****
  1! 2--- 1,2 ----
  1! 20

With this patch:

$ python $LIT_BUILTINS/diff.py -b foo.txt bar.txt
*** /tmp/foo.txt
--- /tmp/bar.txt
***************
*** 1,2 ****
  1
! 2
--- 1,2 ----
  1
! 20

Diff Detail

Event Timeline

jdenny created this revision.Dec 16 2019, 3:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2019, 3:36 PM
Herald added a subscriber: delcypher. · View Herald Transcript
rnk accepted this revision.Dec 16 2019, 3:53 PM

lgtm

This revision is now accepted and ready to land.Dec 16 2019, 3:53 PM

Thanks for the quick review. Will push hopefully tomorrow.

This revision was automatically updated to reflect the committed changes.