Page MenuHomePhabricator

[InstCombine] Add tests for `select + mul` for power of twos. NFC
AcceptedPublic

Authored by danlark on Dec 16 2019, 1:32 PM.

Details

Reviewers
spatel
lebedev.ri
Summary

Add tests for select + mul for power of twos. NFC

Patch by Danila Kutenin. email:danilak at google.com, github:danlark1@ . I don't have commit rights.

Event Timeline

danlark created this revision.Dec 16 2019, 1:32 PM
danlark retitled this revision from [InstCombine] Refactor FoldUDivAction for future usage with multiplication. NFC to [InstCombine] Add tests for `select + mul` for power of twos. NFC.Dec 16 2019, 1:33 PM
danlark edited the summary of this revision. (Show Details)
danlark updated this revision to Diff 234148.Dec 16 2019, 2:04 PM
danlark retitled this revision from [InstCombine] Add tests for `select + mul` for power of twos. NFC to [InstCombine] Add tests for `select + mul` for power of twos. NFC.
danlark edited the summary of this revision. (Show Details)
danlark updated this revision to Diff 234150.Dec 16 2019, 2:06 PM
This comment was removed by danlark.
Harbormaster completed remote builds in B42604: Diff 234150.
danlark updated this revision to Diff 234151.Dec 16 2019, 2:08 PM

Trying to make chain review

danlark updated this revision to Diff 234152.Dec 16 2019, 2:11 PM

Finally readable chain review

You probably want to throw in some vector undef tests as well.
(e.g. a singled lane in one of constants, the same lane in both, different lanes in each)

Also, nuw/nsw/nuw+nsw propagation tests?

danlark updated this revision to Diff 234156.Dec 16 2019, 2:39 PM

Add nsw+nuw tests

danlark updated this revision to Diff 234158.Dec 16 2019, 2:40 PM
This comment was removed by danlark.

You probably want to throw in some vector undef tests as well.
(e.g. a singled lane in one of constants, the same lane in both, different lanes in each)

All done

danlark updated this revision to Diff 234191.Dec 16 2019, 4:48 PM

More robust zext tests

danlark updated this revision to Diff 234235.Dec 17 2019, 12:48 AM

Correct INT_MIN test

danlark updated this revision to Diff 237111.Jan 9 2020, 9:34 AM

Update tests

spatel accepted this revision.Jan 9 2020, 9:35 AM

LGTM

This revision is now accepted and ready to land.Jan 9 2020, 9:35 AM
Harbormaster completed remote builds in B43609: Diff 237112.