Page MenuHomePhabricator

[Attributor] H2S fix.
ClosedPublic

Authored by sstefan1 on Dec 16 2019, 12:36 PM.

Details

Summary

Fixing issues that were noticed in D71521

Diff Detail

Event Timeline

sstefan1 created this revision.Dec 16 2019, 12:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2019, 12:36 PM
lebedev.ri accepted this revision.Dec 16 2019, 12:47 PM

LG, thank you.

llvm/test/Transforms/Attributor/heap_to_stack.ll
314

Precommit the tests?
https://godbolt.org/z/MG49m9

This revision is now accepted and ready to land.Dec 16 2019, 12:47 PM
sstefan1 marked an inline comment as done.Dec 16 2019, 2:06 PM
sstefan1 added inline comments.
llvm/test/Transforms/Attributor/heap_to_stack.ll
314

Just to make sure, you are suggesting to commit tests only first?

What is the difference, other than build bot failures?

lebedev.ri marked an inline comment as done.Dec 16 2019, 2:12 PM
lebedev.ri added inline comments.
llvm/test/Transforms/Attributor/heap_to_stack.ll
314

I'm not sure why would there be failures, that test does not trigger any assertions for me locally?
(Obviously, checklines should be changed before commit)

sstefan1 marked an inline comment as done.Dec 16 2019, 2:19 PM
sstefan1 added inline comments.
llvm/test/Transforms/Attributor/heap_to_stack.ll
314

Ok, I'll commit tests with modified check lines first. Unfortunately I'll have to do that tomorrow.

This revision was automatically updated to reflect the committed changes.