This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Teach removeBitcastsFromLoadStoreOnMinMax not to change the size of a store.
ClosedPublic

Authored by craig.topper on Dec 15 2019, 4:14 PM.

Details

Summary

We can change the type as long as we don't change the size.

Fixes PR44306

Diff Detail

Event Timeline

craig.topper created this revision.Dec 15 2019, 4:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2019, 4:14 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
Jim added a subscriber: Jim.Dec 15 2019, 7:05 PM
lebedev.ri accepted this revision.Dec 16 2019, 4:40 AM
lebedev.ri added a subscriber: lebedev.ri.

Sounds good to me.

llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
558–559

This was even noted here...

This revision is now accepted and ready to land.Dec 16 2019, 4:40 AM
This revision was automatically updated to reflect the committed changes.