[libomptarget] Build most of common/src for amdgcn

[JonChesterfield]

Summary

[libomptarget] Build most of common/src for amdgcn

Excluding parallel.cu, which uses an integer min() from cuda,
Excluding support.cu, which calls malloc that is not yet available for amdgcn

[JonChesterfield]

Enabled by D71404. D71382 is sufficient to compile support.cu if device declarations for malloc, free are provided.

[jdoerfert]

Excluding parallel.cu, which uses an integer min() from cuda,
Excluding support.cu, which calls malloc that is not yet available for amdgcn

Couldn't we provide these functions in the target_impl.h of amdgcn?

I would also rename the files to cpp as they seem to not contain CUDA anymore, correct?

[JonChesterfield]

Couldn't we provide these functions in the target_impl.h of amdgcn?

Indeed. That's the plan. Both have a degree of design choice about them though so were excluded from this patch.

I would also rename the files to cpp as they seem to not contain CUDA anymore, correct?

They do not contain CUDA, other than the atomic functions which could be argued are just C++ anyway, as they appear in the amdgcn implementation. Renaming the files should be done separately to this though as it may upset the nvcc build (and definitely won't upset the amdgcn one).

How do you feel about landing this while I look into the other three points?

[JonChesterfield]

• rebase

[jdoerfert]

LGTM.

openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt

 endif()
 
 get_filename_component(devicertl_base_directory
   ${CMAKE_CURRENT_SOURCE_DIR}
   DIRECTORY)
 
 set(cuda_sources
   ${devicertl_base_directory}/common/src/cancel.cu
-  ${devicertl_base_directory}/common/src/critical.cu)
+  ${devicertl_base_directory}/common/src/critical.cu
+  ${devicertl_base_directory}/common/src/loop.cu
+  ${devicertl_base_directory}/common/src/omptarget.cu
+  ${devicertl_base_directory}/common/src/sync.cu
+  ${devicertl_base_directory}/common/src/task.cu)
 
 set(h_files
   ${CMAKE_CURRENT_SOURCE_DIR}/src/amdgcn_interface.h
   ${CMAKE_CURRENT_SOURCE_DIR}/src/hip_atomics.h
   ${CMAKE_CURRENT_SOURCE_DIR}/src/target_impl.h
   ${devicertl_base_directory}/common/debug.h
   ${devicertl_base_directory}/common/device_environment.h
+  ${devicertl_base_directory}/common/omptarget.h
+  ${devicertl_base_directory}/common/omptargeti.h
   ${devicertl_base_directory}/common/state-queue.h
   ${devicertl_base_directory}/common/state-queuei.h
   ${devicertl_base_directory}/common/support.h)
 
 # for both in-tree and out-of-tree build
 if (NOT CMAKE_ARCHIVE_OUTPUT_DIRECTORY)
   set(OUTPUTDIR ${CMAKE_CURRENT_BINARY_DIR})
 else()