This is an archive of the discontinued LLVM Phabricator instance.

Allow redeclaration of __declspec(uuid)
ClosedPublic

Authored by zahen on Dec 12 2019, 3:42 PM.

Details

Summary

msvc allows a subsequent declaration of a uuid attribute on a struct/class. Mirror this behavior in clang-cl.

Diff Detail

Event Timeline

zahen created this revision.Dec 12 2019, 3:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2019, 3:42 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rnk accepted this revision.Dec 12 2019, 4:25 PM

Seems reasonable, looks good to me.

This revision is now accepted and ready to land.Dec 12 2019, 4:25 PM
zahen added a comment.Dec 17 2019, 8:06 PM

@rnk Can you please submit on my behalf. I don't have commit access.

rnk added a comment.Dec 28 2019, 1:14 PM

@rnk Can you please submit on my behalf. I don't have commit access.

Sorry for the delay, I pushed it today. Thanks!

This revision was automatically updated to reflect the committed changes.