Page MenuHomePhabricator

[clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES
ClosedPublic

Authored by xinxinw1 on Dec 12 2019, 11:44 AM.

Details

Summary

I want to pass some CMake cache files in CLANG_BOOTSTRAP_CMAKE_ARGS as -C <cache file>.cmake arguments. I want to be able to use the values of the bootstrap passthrough variables in the cache files, so the cache file arguments need to be after passthrough variables. This should be safe because the values of passthrough variables are all constants and can't refer to values in CLANG_BOOTSTRAP_CMAKE_ARGS.

Diff Detail

Event Timeline

xinxinw1 created this revision.Dec 12 2019, 11:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2019, 11:45 AM
smeenai accepted this revision.Dec 12 2019, 1:58 PM
smeenai added reviewers: beanz, phosek, compnerd, smeenai.
smeenai added a subscriber: smeenai.

LGTM

This revision is now accepted and ready to land.Dec 12 2019, 1:58 PM
This revision was automatically updated to reflect the committed changes.