Page MenuHomePhabricator

[FormatManager] Upstream and test swift bits for GetCandidateLanguages().
ClosedPublic

Authored by davide on Dec 10 2019, 4:32 PM.

Event Timeline

davide created this revision.Dec 10 2019, 4:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2019, 4:32 PM
aprantl accepted this revision.Dec 10 2019, 5:08 PM

The change looks good with some future refactoring comment inline.

lldb/source/DataFormatters/FormatManager.cpp
588

Unrelated to this change; it seems this should really be a callback into the Language plugin and not hardcoded in LLDB.

This revision is now accepted and ready to land.Dec 10 2019, 5:08 PM

This is not a bad idea after all. Let me see if I can cook something reasonable without getting burned.

Ideally -- if we're able to make this a callback in the language plugins, we don't need this patch at all.

davide closed this revision.Tue, Feb 4, 9:46 AM

Not relevant anymore.