This is an archive of the discontinued LLVM Phabricator instance.

[test][llvm-dwarfdump] Add missing testing for some --debug-* options
ClosedPublic

Authored by jhenderson on Dec 10 2019, 7:48 AM.

Details

Summary

A number of the --debug-* options in llvm-dwarfdump are not particularly well tested. In some cases, the option is only tested as part of testing another feature, or a specific part of the section that the options dump. This change adds four new tests to address some of these holes. It is not aiming to address every hole however.

I kept the --debug-line switch test separate to X86/brief.s because the latter only considers the parts of the line table that are affected by verbose printing, thus missing out things like the header and different values for things like the Line, Column etc registers.

Depends on D71274.

Diff Detail

Event Timeline

jhenderson created this revision.Dec 10 2019, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2019, 7:48 AM
JDevlieghere accepted this revision.Dec 10 2019, 10:13 AM

LGTM. Thanks for improving the coverage!

This revision is now accepted and ready to land.Dec 10 2019, 10:13 AM
This revision was automatically updated to reflect the committed changes.