Page MenuHomePhabricator

[FormatManager] GetCandidateLanguages shouldn't know about ValueObject.
ClosedPublic

Authored by davide on Dec 9 2019, 5:05 PM.

Diff Detail

Event Timeline

davide created this revision.Dec 9 2019, 5:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2019, 5:05 PM

I'm assuming you already checked that this isn't used in swift-lldb either? Otherwise this obviously LGTM.

JDevlieghere accepted this revision.Dec 9 2019, 5:15 PM
This revision is now accepted and ready to land.Dec 9 2019, 5:15 PM
This revision was automatically updated to reflect the committed changes.

I'm assuming you already checked that this isn't used in swift-lldb either? Otherwise this obviously LGTM.

This is answering the question "which languages have formatters that are compatible with this language." You should not need a live value to determine that, it is a feature of each language. So even if Swift is using the ValueObject version of this, it shouldn't be, and should switch to the LanguageType version.