This is an archive of the discontinued LLVM Phabricator instance.

[llvm/dwarfdump] Use the architecture string to filter.
ClosedPublic

Authored by JDevlieghere on Dec 9 2019, 4:21 PM.

Details

Summary

Currently dwarfdump uses the ArchType to filter out architectures, which is problematic for architectures like arm64e and x86_64h that map back to arm64 and x86_64 respectively. The result is that the filter doesn't work for these architectures which is usually the reason to use the filter in the first place.

Instead, we should match the architecture based on the string name. This means the filter works for the values printed by dwarfdump. It has the unfortunate side effect of not working for aliases, like AArch64, but I think that's worth the trade-off.

rdar://53653014

Diff Detail

Repository
rLLDB LLDB

Event Timeline

JDevlieghere created this revision.Dec 9 2019, 4:21 PM
Herald added a project: Restricted Project. · View Herald Transcript
JDevlieghere edited the summary of this revision. (Show Details)Dec 9 2019, 4:28 PM

Build result: pass - 60660 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

aprantl accepted this revision.Dec 9 2019, 5:12 PM

Yeah I don't think much value is lost here. Thanks!

This revision is now accepted and ready to land.Dec 9 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.