[Matrix] Propagate and use shape information for loads.
ClosedPublic
Actions

Authored by fhahn on Dec 2 2019, 5:52 AM.

Details

Reviewers

anemet
Gerolf
hfinkel
andrew.w.kaylor
reames

Commits

rG40ff955c6187: [Matrix] Propagate and use shape information for loads.
rG7adf6644f50a: [Matrix] Propagate and use shape information for loads.

Summary

This patch extends to shape propagation to also include load
instructions and implements shape aware lowering for vector loads.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

fhahn created this revision.Dec 2 2019, 5:52 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2019, 5:52 AM

Herald added a subscriber: hiraditya. · View Herald Transcript

fhahn added a child revision: D70899: [Matrix] Implement back-propagation of shape information..Dec 2 2019, 5:52 AM

Build result: FAILURE - Could not check out parent git hash "f906520f30c8c484ead15ab42098d5fc35275230". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead...

ERROR: arc patch failed with error code 1. Check build log for details.
Log files: console-log.txt, CMakeCache.txt

tschuett added a subscriber: tschuett.Dec 2 2019, 5:56 AM

Harbormaster failed remote builds in B41709: Diff 231688!Dec 2 2019, 6:01 AM

reames resigned from this revision.Dec 2 2019, 4:50 PM

fhahn mentioned this in D70897: [Matrix] Add forward shape propagation and first shape aware lowerings..Dec 8 2019, 3:24 AM

LuoYuanke added a subscriber: LuoYuanke.Dec 8 2019, 4:02 AM

ping

I am confused about this patch and the previous one (D70899). Looks like they both introduce VisitLoad. Is this intentional?

anemet requested changes to this revision.Dec 19 2019, 3:14 PM

This revision now requires changes to proceed.Dec 19 2019, 3:14 PM

[Matrix] Propagate and use shape information for loads.

I am confused about this patch and the previous one (D70899). Looks like they both introduce VisitLoad. Is this intentional?

No, it looks like I did not update D70899 after this one. I've updated the D70899 to not include the load lowering changes and updated the tests to only show the changes.

TO make that easier I adjusted computeColumnAddr to give the values more meaningful names.

Unit tests: unknown.

clang-tidy: unknown.

clang-format: unknown.

Build artifacts: diff.json, console-log.txt

Harbormaster failed remote builds in B42826: Diff 234873!Dec 20 2019, 5:51 AM

ping

LGTM.

This revision is now accepted and ready to land.Jan 7 2020, 6:21 PM

Thanks! I'll land this and the related patches tomorrow.

fhahn removed a child revision: D70899: [Matrix] Implement back-propagation of shape information..Jan 9 2020, 1:30 AM

Closed by commit rG7adf6644f50a: [Matrix] Propagate and use shape information for loads. (authored by fhahn). · Explain WhyJan 9 2020, 2:26 AM