This is an archive of the discontinued LLVM Phabricator instance.

[PatternMatch] Add support for matching intrinsics with 5 operands.
ClosedPublic

Authored by fhahn on Dec 2 2019, 3:52 AM.

Details

Diff Detail

Event Timeline

fhahn created this revision.Dec 2 2019, 3:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2019, 3:52 AM
fhahn updated this revision to Diff 231669.Dec 2 2019, 3:55 AM

Fix formatting glitch.

LGTM to the PatternMatch.h change, but not sure the test works?

fhahn added a comment.Dec 2 2019, 6:03 AM

LGTM to the PatternMatch.h change, but not sure the test works?

There was a build error in the first revision, but that's fixed with the latest version. The merge_guard_bot picked up the first one, not sure if it automatically also picks up the second one.

spatel accepted this revision.Dec 2 2019, 6:39 AM

LGTM

llvm/unittests/IR/PatternMatch.cpp
1193

typo: forth -> fourth

This revision is now accepted and ready to land.Dec 2 2019, 6:39 AM
fhahn marked an inline comment as done.Dec 2 2019, 7:31 AM

Thanks for the quick review :)

llvm/unittests/IR/PatternMatch.cpp
1193

thanks, will fix before committing!

This revision was automatically updated to reflect the committed changes.