[lldb] Use explicit lldb commands on tests

[aadsm]

Summary

Not a big deal but might be if in the future we had another command starting with br.
I found this because I had an lldbinit that added a breakpad command.

[clayborg]

We shouldn't be running the test suite that allows your ~/.lldbinit file to be run. This can really hose up many things, so we should change the lldb-vscode test suite to not allow your ~/.lldbinit file to be loaded instead?

[aadsm]

Yeah, that's what I do in D70882. I still think tests can be more robust by using explicit lldb command names but don't really care much :). I'm happy to abandon it.

[jingham]

I don't think it is wise to use shortened command names like "br" in a test if you aren't testing shortest command string. We don't guarantee that we will keep all currently unique shortened command names unique in perpetuity...

[lanza]

Sorry for bump to this old diff, but I agree with both Jim and Greg -- we shouldn't be importing your ~/.lldbinit, but tests shouldn't depend on there never being another br s. This change should land as breakpoint set.

[clayborg]

lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/launch/TestVSCode_launch.py

353–354 ↗

(On Diff #231632)

we might as well spell this out completely as "breakpoint set" just in case and nothing can currently replace or alias existing commands.

[aadsm]

Use set and rebase

[JDevlieghere]

LGTM

lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

def test_extra_launch_commands(self):
         first_line = line_number(source, '// breakpoint 1')
         second_line = line_number(source, '// breakpoint 2')
         # Set target binary and 2 breakpoints
         # then we can varify the "launchCommands" get run
         # also we can verify that "stopCommands" get run as the
         # breakpoints get hit
         launchCommands = [
             'target create "%s"' % (program),
-            'br s -f main.c -l %d' % first_line,
-            'br s -f main.c -l %d' % second_line,
+            'breakpoint set -f main.c -l %d' % first_line,
+            'breakpoint set -f main.c -l %d' % second_line,
             'process launch --stop-at-entry'
         ]
 
         initCommands = ['target list', 'platform list']
         preRunCommands = ['image list a.out', 'image dump sections a.out']
         stopCommands = ['frame variable', 'bt']
         exitCommands = ['expr 2+3', 'expr 3+4']
         self.launch(program,