Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
You may be able to re-use the existing DAG select tests at this point?
llvm/lib/Target/AMDGPU/AMDGPUGenRegisterBankInfo.def | ||
---|---|---|
35–41 | I think a 96 bit one is needed for symmetry to legalize all the vector operations | |
llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp | ||
186 | Indented too much, and no else after return | |
llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h | ||
139 | This can be static |
llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp | ||
---|---|---|
124 | I think the cost actually needs to go up if src and dst are AGPRs since there is no direct copy between them |
llvm/lib/Target/AMDGPU/AMDGPUGenRegisterBankInfo.def | ||
---|---|---|
36 | This is going to cause an annoying merge conflict with one of my patches. It would be nice to start finally having tablegen emit this | |
llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp | ||
148–149 | Should just directly check if they are AGPR. This incorrectly covers VGPR copies? | |
2130 | Extra newline |
LGTM, I don't think it's avoidable since the renumbering of the hardcoded indexes is the painful part
This is going to cause an annoying merge conflict with one of my patches. It would be nice to start finally having tablegen emit this