This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Find reference to template parameter in 'sizeof...' expression
ClosedPublic

Authored by nridge on Nov 26 2019, 12:24 PM.

Event Timeline

nridge created this revision.Nov 26 2019, 12:24 PM

Thanks! Could you also handle this in targetDecl and add the corresponding test?

nridge updated this revision to Diff 231608.Nov 30 2019, 9:10 PM

Address review comment

ilya-biryukov added a comment.EditedDec 2 2019, 5:11 AM

Could you add another test for findExplicitReferences too? Those tests are right after targetDecl.
These two functions kinda duplicate each other a lot, but that's intentional - those two functions do a somewhat similar thing and we want to keep them in sync (put another way, we want to fix bugs in both simultaneously)

nridge updated this revision to Diff 232011.Dec 3 2019, 4:19 PM

Add FindExplicitReferences test

ilya-biryukov accepted this revision.Dec 4 2019, 12:47 AM

LGTM! Many thanks!

This revision is now accepted and ready to land.Dec 4 2019, 12:47 AM
This revision was automatically updated to reflect the committed changes.