Page MenuHomePhabricator

[clangd] Keep go-to-definition working at the end of an identifier (fixes #194)
AbandonedPublic

Authored by nridge on Nov 26 2019, 9:43 AM.

Details

Reviewers
hokein

Event Timeline

nridge created this revision.Nov 26 2019, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2019, 9:43 AM

By the way, may I get permissions to assign issues to myself (and make other such metadata changes to issues) on github?

By the way, may I get permissions to assign issues to myself (and make other such metadata changes to issues) on github?

sure, we just sent you an invitation to the clangd org.

clang-tools-extra/clangd/XRefs.cpp
153

this looks a hacky workaround, I assume it may introduce other regression issues.

I think https://reviews.llvm.org/D70773 and https://reviews.llvm.org/D70807 should fix most annoying cases (function call).

By the way, may I get permissions to assign issues to myself (and make other such metadata changes to issues) on github?

sure, we just sent you an invitation to the clangd org.

Thanks!

nridge abandoned this revision.Nov 30 2019, 9:24 PM
nridge marked an inline comment as done.
nridge added inline comments.
clang-tools-extra/clangd/XRefs.cpp
153

Fair enough! Will abandon this patch.