This is an archive of the discontinued LLVM Phabricator instance.

Differential D70707

[hwasan] Make memory dump same as the one in asan.
ClosedPublic

Authored by marxin on Nov 26 2019, 1:27 AM.

Details

Reviewers
kcc
vitalybuka
eugenis
pcc
Commits
rG2045d2c90e24: Make memory dump same as the one in asan.
Summary

Shadow memory (and short granules) are not prepended with memory
address and arrow at the end of line is removed.

Diff Detail

Event Timeline

marxin created this revision.Nov 26 2019, 1:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2019, 1:27 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
marxin added a comment.Nov 26 2019, 1:28 AM

Old report look:

Memory tags around the buggy address (one tag corresponds to 16 bytes):
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
=> d7  00 [08] 00  00  00  00  00  00  00  00  00  00  00  00  00 <=
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
   00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00   
Tags for short granules around the buggy address (one tag corresponds to 16 bytes):
   ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..   
=> ..  .. [be] ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  .. <=
   ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..

New report look:

Thread: T0 0xeffe00002000 stack: [0xffffc1759000,0xffffc1f59000) sz: 8388608 tls: [0xffff911ced20,0xffff911cf470)
Memory tags around the buggy address (one tag corresponds to 16 bytes):
  0xfefceffffd80: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffd90: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffda0: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffdb0: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffdc0: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffdd0: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffde0: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffdf0: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
=>0xfefceffffe00: 3f  00 [8c] 00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffe10: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffe20: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffe30: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffe40: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffe50: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffe60: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffe70: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
  0xfefceffffe80: 00  00  00  00  00  00  00  00  00  00  00  00  00  00  00  00 
Tags for short granules around the buggy address (one tag corresponds to 16 bytes):
  0xfefceffffdf0: ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  .. 
=>0xfefceffffe00: ..  .. [..] ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  .. 
  0xfefceffffe10: ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  ..  .. 
See https://clang.llvm.org/docs/HardwareAssistedAddressSanitizerDesign.html#short-granules for a description of short granule tags
vitalybuka added reviewers: eugenis, pcc.Nov 26 2019, 1:27 PM

LGTM

pcc added a comment.Nov 26 2019, 1:39 PM

Test case? (Do none of the tests really need to be updated?)

marxin added a comment.Nov 27 2019, 9:47 AM
In D70707#1760759, @pcc wrote:

Test case? (Do none of the tests really need to be updated?)

No, tests do not need to be updated. I've just installed the patch.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2019, 9:50 AM
Closed by commit rG2045d2c90e24: Make memory dump same as the one in asan. (authored by marxin). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 27 2019, 9:50 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Revision Contents

PathSize
compiler-rt/
lib/
hwasan/
3 lines

Diff 231289

compiler-rt/lib/hwasan/hwasan_report.cpp

Show First 20 Lines • Show All 365 Lines • ▼ Show 20 Linesstatic void PrintTagInfoAroundAddr(tag_t *tag_ptr, uptr num_rows,
const uptr row_len = 16; // better be power of two. const uptr row_len = 16; // better be power of two.
tag_t *center_row_beg = reinterpret_cast<tag_t *>( tag_t *center_row_beg = reinterpret_cast<tag_t *>(
RoundDownTo(reinterpret_cast<uptr>(tag_ptr), row_len)); RoundDownTo(reinterpret_cast<uptr>(tag_ptr), row_len));
tag_t *beg_row = center_row_beg - row_len * (num_rows / 2); tag_t *beg_row = center_row_beg - row_len * (num_rows / 2);
tag_t *end_row = center_row_beg + row_len * ((num_rows + 1) / 2); tag_t *end_row = center_row_beg + row_len * ((num_rows + 1) / 2);
InternalScopedString s(GetPageSizeCached() * 8); InternalScopedString s(GetPageSizeCached() * 8);
for (tag_t *row = beg_row; row < end_row; row += row_len) { for (tag_t *row = beg_row; row < end_row; row += row_len) {
s.append("%s", row == center_row_beg ? "=>" : " "); s.append("%s", row == center_row_beg ? "=>" : " ");
s.append("%p:", row);
for (uptr i = 0; i < row_len; i++) { for (uptr i = 0; i < row_len; i++) {
s.append("%s", row + i == tag_ptr ? "[" : " "); s.append("%s", row + i == tag_ptr ? "[" : " ");
print_tag(s, &row[i]); print_tag(s, &row[i]);
s.append("%s", row + i == tag_ptr ? "]" : " "); s.append("%s", row + i == tag_ptr ? "]" : " ");
} }
s.append("%s\n", row == center_row_beg ? "<=" : " "); s.append("\n");
} }
Printf("%s", s.data()); Printf("%s", s.data());
} }
static void PrintTagsAroundAddr(tag_t *tag_ptr) { static void PrintTagsAroundAddr(tag_t *tag_ptr) {
Printf( Printf(
"Memory tags around the buggy address (one tag corresponds to %zd " "Memory tags around the buggy address (one tag corresponds to %zd "
"bytes):\n", kShadowAlignment); "bytes):\n", kShadowAlignment);
▲ Show 20 Lines • Show All 185 Lines • Show Last 20 Lines