This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Disable clang python binding tests
ClosedPublic

Authored by daltenty on Nov 25 2019, 9:17 AM.

Download Raw Diff

Details

Reviewers

stevewan
jasonliu
hubert.reinterpretcast
mgorny

Commits

rGa38fc6164879: [AIX] Disable clang python binding tests

Summary

The Python ctypes FFI interface is broken on AIX, it cannot properly pass
structures containing arrays ( https://bugs.python.org/issue38628). So
disable the clang python binding tests on AIX till this is resolved.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

daltenty created this revision.Nov 25 2019, 9:17 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 25 2019, 9:17 AM

Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript

Harbormaster completed remote builds in B41452: Diff 230917.Nov 25 2019, 9:19 AM

daltenty added reviewers: stevewan, jasonliu, hubert.reinterpretcast, mgorny.Nov 25 2019, 9:22 AM

LGTM.

This revision is now accepted and ready to land.Nov 26 2019, 10:53 AM

Agreed. LGTM as well.

Closed by commit rGa38fc6164879: [AIX] Disable clang python binding tests (authored by daltenty). · Explain WhyNov 26 2019, 12:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

clang/

bindings/

python/

tests/

CMakeLists.txt

5 lines

Diff 231121

clang/bindings/python/tests/CMakeLists.txt

	Show All 26 Lines
	endif()			endif()

	# Tests fail on Windows, and need someone knowledgeable to fix.			# Tests fail on Windows, and need someone knowledgeable to fix.
	# It's not clear whether it's a test or a valid binding problem.			# It's not clear whether it's a test or a valid binding problem.
	if(WIN32)			if(WIN32)
	set(RUN_PYTHON_TESTS FALSE)			set(RUN_PYTHON_TESTS FALSE)
	endif()			endif()

				# The Python FFI interface is broken on AIX: https://bugs.python.org/issue38628.
				if(${CMAKE_SYSTEM_NAME} MATCHES "AIX")
				set(RUN_PYTHON_TESTS FALSE)
				endif()

	# AArch64, Hexagon, and Sparc have known test failures that need to be			# AArch64, Hexagon, and Sparc have known test failures that need to be
	# addressed.			# addressed.
	# SystemZ has broken Python/FFI interface:			# SystemZ has broken Python/FFI interface:
	# https://reviews.llvm.org/D52840#1265716			# https://reviews.llvm.org/D52840#1265716
	if(${LLVM_NATIVE_ARCH} MATCHES "^(AArch64\|Hexagon\|Sparc\|SystemZ)$")			if(${LLVM_NATIVE_ARCH} MATCHES "^(AArch64\|Hexagon\|Sparc\|SystemZ)$")
	set(RUN_PYTHON_TESTS FALSE)			set(RUN_PYTHON_TESTS FALSE)
	endif()			endif()

	if(RUN_PYTHON_TESTS)			if(RUN_PYTHON_TESTS)
	set_property(GLOBAL APPEND PROPERTY			set_property(GLOBAL APPEND PROPERTY
	LLVM_ADDITIONAL_TEST_TARGETS check-clang-python)			LLVM_ADDITIONAL_TEST_TARGETS check-clang-python)
	endif()			endif()