Page MenuHomePhabricator

[SCEV] Make SCEV verification available from command line with new PM
ClosedPublic

Authored by DaniilSuchkov on Nov 19 2019, 1:36 AM.

Details

Summary

New pass manager doesn't use verifyAnalysis, so currently there is no way to call SCEV verification from command line when new PM is used. This patch adds a pass that allows you to do that.

Diff Detail

Event Timeline

DaniilSuchkov created this revision.Nov 19 2019, 1:36 AM
fhahn added a comment.Nov 22 2019, 9:07 AM

I might be missing something obvious, but is the motivation for adding this that the new pass manager does not use verifyAnalysis like the legacy pass manager? If that's the case, it would be great if you could clarify that in the title/description.

DaniilSuchkov edited the summary of this revision. (Show Details)Nov 22 2019, 10:42 AM
DaniilSuchkov retitled this revision from [SCEV] Introduce ScalarEvolutionVerifierPass to [SCEV] Make SCEV verification available from command line with new PM.Nov 22 2019, 10:58 AM

I might be missing something obvious, but is the motivation for adding this that the new pass manager does not use verifyAnalysis like the legacy pass manager? If that's the case, it would be great if you could clarify that in the title/description.

You're right. Now it is better?

LGTM, thanks. Please wait a day or two with committing, in case there are additional suggestions. Also it would be great if you could also invoke the pass in a test.

fhahn accepted this revision.Nov 22 2019, 12:59 PM
This revision is now accepted and ready to land.Nov 22 2019, 12:59 PM
This revision was automatically updated to reflect the committed changes.