- User Since
- Sep 5 2017, 3:03 AM (147 w, 6 d)
May 27 2020
May 26 2020
Mar 6 2020
Mar 5 2020
Apparently, it breaks MSVC buildbots too, but it does it in a way I can't comprehend: looks like after my change MSVC instantiates all methods of BlockFrequencyInfoImpl, including ones that weren't instantiated before and which are incorrect for <MachineBasicBlock> instantiation. I don't have access to MSVC, so there's no way I'll figure out what's wrong with it and fix it.
Following resubmission of this patch:
commit 8975aa6ea8172963d6532caa8ed2a6f6e0074a02 Author: Daniil Suchkov <firstname.lastname@example.org> Date: Thu Mar 5 18:32:50 2020 +0700
Hi! I had to revert this patch because following test results in SIGSEGV and passes with the patch reverted (you can find it at llvm/test/Transforms/LoopRotate/freeze-crash.ll):
; RUN: opt -loop-rotate -disable-output %s
Hi! Unfortunately I had to revert this patch, see my comment here: https://reviews.llvm.org/rG952ad4701cf0d8da79789f6b83ddaa386c60d535
Mar 4 2020
Actually, this change will even help CheckBFIUnknownBlockQueries: since every missed update will result in a missing NodesMap entry, without exclusion of cases when new BB happens to be in the same address where some old BB was.
Mar 3 2020
You mean we don't need to update BFI in non-asserting mode? It's not just for verification, it's required for correctness.
Mar 1 2020
Got rid of all const_casts except one, which was moved into CallbackVH's constructor.
Feb 28 2020
One thing I don't understand is why three out of four kinds of VHs perform the const_cast, not the ValueHandleBase. I think it's time to change that (and by doing so, allow CallbackVH accept const pointers too).
Given that three out of four VH kinds already perform const_cast inside, I think it makes sense to add one to CallbackVH too.
Jan 23 2020
Jan 22 2020
Jan 21 2020
Jan 20 2020
Given this comment: https://bugs.llvm.org/show_bug.cgi?id=44320#c3 there is a better solution than this patch.
Jan 17 2020
Dec 5 2019
Dec 1 2019
Nov 27 2019
Nov 25 2019
Nov 22 2019
Nov 19 2019
Nov 18 2019
Nov 14 2019
Nov 13 2019
Nov 12 2019
Nov 10 2019
Nov 8 2019
Removed support of non-inbounds pointers.
Nov 7 2019
Oct 28 2019
Oct 24 2019
@asbirlea could you please also take a look at the parent revision for this patch that adds the unit test (D69369)?
And if everything looks good, may I ask you to submit both patches? I don't have commit access yet.
Oct 17 2019
Added a comment explaining how IsInBounds is set by stripAndAccumulateConstantOffsets.
Oct 14 2019
Oct 1 2019
Test checks updated.
Comment addressed: got rid of duplicating checks with different prefixes.
Comments addressed: checks in tests are autogenerated, positive tests moved to a separate patch D68263, got rid of excessive use of auto keyword.